From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] qdev property listing broken
Date: Tue, 03 Apr 2012 00:03:09 +0200 [thread overview]
Message-ID: <4F7A221D.1070307@redhat.com> (raw)
In-Reply-To: <CAFEAcA___AqMzbHNjCr2AcbB5_s5p18wYHUL9ngXy1amhdUJ7Q@mail.gmail.com>
Il 02/04/2012 22:07, Peter Maydell ha scritto:
> On 2 April 2012 20:40, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c
>> index a310cc7..923519c 100644
>> --- a/hw/qdev-monitor.c
>> +++ b/hw/qdev-monitor.c
>> @@ -157,7 +157,7 @@ int qdev_device_help(QemuOpts *opts)
>> * for removal. This conditional should be removed along with
>> * it.
>> */
>> - if (!prop->info->parse) {
>> + if (!prop->info->get) {
>> continue; /* no way to set it, don't show */
>> }
>
> This looks really weird: there's no "get" method so we conclude
> "no way to *set* it" ?? Is the comment wrong?
See the comment above.
Paolo
next prev parent reply other threads:[~2012-04-02 22:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 19:33 [Qemu-devel] qdev property listing broken Jan Kiszka
2012-04-02 19:40 ` Paolo Bonzini
2012-04-02 19:43 ` Anthony Liguori
2012-04-02 20:07 ` Peter Maydell
2012-04-02 22:03 ` Paolo Bonzini [this message]
2012-04-02 22:27 ` Peter Maydell
2012-04-03 7:12 ` Paolo Bonzini
2012-04-02 23:38 ` Jan Kiszka
2012-04-02 19:41 ` Anthony Liguori
2012-04-02 19:44 ` Jan Kiszka
2012-04-02 19:48 ` Anthony Liguori
2012-04-02 19:50 ` Jan Kiszka
2012-04-02 20:07 ` Jan Kiszka
2012-04-02 20:10 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7A221D.1070307@redhat.com \
--to=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).