From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46927)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SEpLM-0007DC-5I
	for qemu-devel@nongnu.org; Mon, 02 Apr 2012 18:03:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SEpLI-00065z-SC
	for qemu-devel@nongnu.org; Mon, 02 Apr 2012 18:03:19 -0400
Received: from mail-wi0-f175.google.com ([209.85.212.175]:39185)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SEpLI-00065J-J8
	for qemu-devel@nongnu.org; Mon, 02 Apr 2012 18:03:16 -0400
Received: by wibhn6 with SMTP id hn6so2725143wib.10
	for <qemu-devel@nongnu.org>; Mon, 02 Apr 2012 15:03:14 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4F7A221D.1070307@redhat.com>
Date: Tue, 03 Apr 2012 00:03:09 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <4F79FF0E.9090701@web.de> <jlcvat$crm$1@dough.gmane.org>
	<CAFEAcA___AqMzbHNjCr2AcbB5_s5p18wYHUL9ngXy1amhdUJ7Q@mail.gmail.com>
In-Reply-To: <CAFEAcA___AqMzbHNjCr2AcbB5_s5p18wYHUL9ngXy1amhdUJ7Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] qdev property listing broken
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org

Il 02/04/2012 22:07, Peter Maydell ha scritto:
> On 2 April 2012 20:40, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c
>> index a310cc7..923519c 100644
>> --- a/hw/qdev-monitor.c
>> +++ b/hw/qdev-monitor.c
>> @@ -157,7 +157,7 @@ int qdev_device_help(QemuOpts *opts)
>>          * for removal.  This conditional should be removed along with
>>          * it.
>>          */
>> -        if (!prop->info->parse) {
>> +        if (!prop->info->get) {
>>             continue;           /* no way to set it, don't show */
>>         }
> 
> This looks really weird: there's no "get" method so we conclude
> "no way to *set* it" ?? Is the comment wrong?

See the comment above.

Paolo