From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38491)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1SEqpE-0000lS-Ob
	for qemu-devel@nongnu.org; Mon, 02 Apr 2012 19:38:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1SEqpD-0002gI-2v
	for qemu-devel@nongnu.org; Mon, 02 Apr 2012 19:38:16 -0400
Received: from fmmailgate06.web.de ([217.72.192.247]:34562)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1SEqpC-0002g8-PO
	for qemu-devel@nongnu.org; Mon, 02 Apr 2012 19:38:14 -0400
Received: from moweb001.kundenserver.de (moweb001.kundenserver.de
	[172.19.20.114])
	by fmmailgate06.web.de (Postfix) with ESMTP id 314EC10813BD
	for <qemu-devel@nongnu.org>; Tue,  3 Apr 2012 01:38:13 +0200 (CEST)
Message-ID: <4F7A3860.7000504@web.de>
Date: Tue, 03 Apr 2012 01:38:08 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <4F79FF0E.9090701@web.de> <jlcvat$crm$1@dough.gmane.org>
In-Reply-To: <jlcvat$crm$1@dough.gmane.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig7B8D2964AABA65FB6DFBF82C"
Subject: Re: [Qemu-devel] qdev property listing broken
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig7B8D2964AABA65FB6DFBF82C
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 2012-04-02 21:40, Paolo Bonzini wrote:
> diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c
> index a310cc7..923519c 100644
> --- a/hw/qdev-monitor.c
> +++ b/hw/qdev-monitor.c
> @@ -157,7 +157,7 @@ int qdev_device_help(QemuOpts *opts)
>           * for removal.  This conditional should be removed along with=

>           * it.
>           */
> -        if (!prop->info->parse) {
> +        if (!prop->info->get) {
>              continue;           /* no way to set it, don't show */
>          }
>          error_printf("%s.%s=3D%s\n", driver, prop->name,
> @@ -165,7 +165,7 @@ int qdev_device_help(QemuOpts *opts)
>      }
>      if (info->bus_info) {
>          for (prop =3D info->bus_info->props; prop && prop->name; prop+=
+) {
> -            if (!prop->info->parse) {
> +            if (!prop->info->get) {
>                  continue;           /* no way to set it, don't show */=

>              }
>              error_printf("%s.%s=3D%s\n", driver, prop->name,

[ missed this as CCs were dropped ]

This fixes the -device foo,?, but not the issue I'm seeing. Non-legacy
properties are still not printed in info qtree - which is no surprise
given the inconsistency I pointed out.

Jan


--------------enig7B8D2964AABA65FB6DFBF82C
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk96OGMACgkQitSsb3rl5xRZLQCeJwaMrvMJ1jfZCpaXZ4pmg+Fm
ODUAn3b3+Ipd641y26dk24xD2F74Qdca
=Wtzz
-----END PGP SIGNATURE-----

--------------enig7B8D2964AABA65FB6DFBF82C--