From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40462)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SExvN-0007MN-LW
	for qemu-devel@nongnu.org; Tue, 03 Apr 2012 03:13:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SExvH-0006cZ-Ds
	for qemu-devel@nongnu.org; Tue, 03 Apr 2012 03:13:05 -0400
Received: from mail-pz0-f46.google.com ([209.85.210.46]:38638)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SExvH-0006cC-5J
	for qemu-devel@nongnu.org; Tue, 03 Apr 2012 03:12:59 -0400
Received: by dadz9 with SMTP id z9so3924531dad.33
	for <qemu-devel@nongnu.org>; Tue, 03 Apr 2012 00:12:57 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4F7AA2F2.3050904@redhat.com>
Date: Tue, 03 Apr 2012 09:12:50 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <4F79FF0E.9090701@web.de> <jlcvat$crm$1@dough.gmane.org>
	<CAFEAcA___AqMzbHNjCr2AcbB5_s5p18wYHUL9ngXy1amhdUJ7Q@mail.gmail.com>
	<4F7A221D.1070307@redhat.com>
	<CAFEAcA_dzrP9eBU0tSZEVkBKd_9MrcL7hkjorPVtN2=XUJmYYw@mail.gmail.com>
In-Reply-To: <CAFEAcA_dzrP9eBU0tSZEVkBKd_9MrcL7hkjorPVtN2=XUJmYYw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] qdev property listing broken
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org

Il 03/04/2012 00:27, Peter Maydell ha scritto:
> On 2 April 2012 23:03, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> Il 02/04/2012 22:07, Peter Maydell ha scritto:
>>> On 2 April 2012 20:40, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>>> diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c
>>>> index a310cc7..923519c 100644
>>>> --- a/hw/qdev-monitor.c
>>>> +++ b/hw/qdev-monitor.c
>>>> @@ -157,7 +157,7 @@ int qdev_device_help(QemuOpts *opts)
>>>>          * for removal.  This conditional should be removed along with
>>>>          * it.
>>>>          */
>>>> -        if (!prop->info->parse) {
>>>> +        if (!prop->info->get) {
>>>>             continue;           /* no way to set it, don't show */
>>>>         }
>>>
>>> This looks really weird: there's no "get" method so we conclude
>>> "no way to *set* it" ?? Is the comment wrong?
>>
>> See the comment above.
> 
> You mean
>         /*
>          * TODO Properties without a parser are just for dirty hacks.
>          * qdev_prop_ptr is the only such PropertyInfo.  It's marked
>          * for removal.  This conditional should be removed along with
>          * it.
>          */
> ?
> 
> That also looks odd now because we're no longer testing whether the
> property has a parser... (plus doesn't qdev_prop_vlan also have no
> parser ?)

Oops... parse is set, print is get.  It was too late...

Paolo