From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60062)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <julien.grall@citrix.com>) id 1SF0BO-0001qE-02
	for qemu-devel@nongnu.org; Tue, 03 Apr 2012 05:37:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <julien.grall@citrix.com>) id 1SF0BM-00021a-7y
	for qemu-devel@nongnu.org; Tue, 03 Apr 2012 05:37:45 -0400
Received: from smtp02.citrix.com ([66.165.176.63]:48676)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <julien.grall@citrix.com>) id 1SF0BM-00021U-3W
	for qemu-devel@nongnu.org; Tue, 03 Apr 2012 05:37:44 -0400
Message-ID: <4F7AC4FB.2070702@citrix.com>
Date: Tue, 3 Apr 2012 10:38:03 +0100
From: Julien Grall <julien.grall@citrix.com>
MIME-Version: 1.0
References: <a6fb7184d69364f152ef03df0e73070c0b43a77c.1333377087.git.julien.grall@citrix.com>
	<4F7AAC02.6090606@redhat.com>
In-Reply-To: <4F7AAC02.6090606@redhat.com>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Memory: unify ioport registration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Julian Pidancet <julian.pidancet@citrix.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Anthony Liguori <anthony@codemonkey.ws>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>

On 04/03/2012 08:51 AM, Avi Kivity wrote:
> On 04/02/2012 05:37 PM, Julien Grall wrote:
>    
>>       if (!inited) {
>>           inited = 1;
>> @@ -2814,19 +2830,8 @@ static void cirrus_init_common(CirrusVGAState * s, int device_id, int is_pci,
>>               s->bustype = CIRRUS_BUSTYPE_ISA;
>>       }
>>
>> -    register_ioport_write(0x3c0, 16, 1, cirrus_vga_ioport_write, s);
>> -
>> -    register_ioport_write(0x3b4, 2, 1, cirrus_vga_ioport_write, s);
>> -    register_ioport_write(0x3d4, 2, 1, cirrus_vga_ioport_write, s);
>> -    register_ioport_write(0x3ba, 1, 1, cirrus_vga_ioport_write, s);
>> -    register_ioport_write(0x3da, 1, 1, cirrus_vga_ioport_write, s);
>> -
>> -    register_ioport_read(0x3c0, 16, 1, cirrus_vga_ioport_read, s);
>> -
>> -    register_ioport_read(0x3b4, 2, 1, cirrus_vga_ioport_read, s);
>> -    register_ioport_read(0x3d4, 2, 1, cirrus_vga_ioport_read, s);
>> -    register_ioport_read(0x3ba, 1, 1, cirrus_vga_ioport_read, s);
>> -    register_ioport_read(0x3da, 1, 1, cirrus_vga_ioport_read, s);
>> +    portio_list_init(cirrus_port_list, cirrus_portio_list, s, "cirrus-io");
>> +    portio_list_add(cirrus_port_list, get_system_io(), 0x3b0);
>>
>>      
> Please pass either pci_address_space_io() or isa_io_address_space()
> (you'll have to write the latter) to cirrus_init_common() from its
> callers.  We really want to avoid get_system_io().
>
>    
isa_io_address_space doesn't exist. I will create it, but which
memory region we need to return ? get_system_io () ?