From: Avi Kivity <avi@redhat.com>
To: Julien Grall <julien.grall@citrix.com>
Cc: Julian Pidancet <julian.pidancet@citrix.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Anthony Liguori <anthony@codemonkey.ws>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: Re: [Qemu-devel] [PATCH] Memory: unify ioport registration
Date: Tue, 03 Apr 2012 13:09:33 +0300 [thread overview]
Message-ID: <4F7ACC5D.4090708@redhat.com> (raw)
In-Reply-To: <4F7AC4FB.2070702@citrix.com>
On 04/03/2012 12:38 PM, Julien Grall wrote:
>> Please pass either pci_address_space_io() or isa_io_address_space()
>> (you'll have to write the latter) to cirrus_init_common() from its
>> callers. We really want to avoid get_system_io().
>>
>>
> isa_io_address_space doesn't exist. I will create it, but which
> memory region we need to return ? get_system_io () ?
>
Yes. The point it that we can later remove that get_system_io() in one
place, instead of many.
Please add isa_io_address_space() in a separate patch.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-04-03 10:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 14:37 [Qemu-devel] [PATCH] Memory: unify ioport registration Julien Grall
2012-04-03 7:51 ` Avi Kivity
2012-04-03 9:38 ` Julien Grall
2012-04-03 10:09 ` Avi Kivity [this message]
2012-04-04 15:55 ` Julien Grall
2012-04-05 9:58 ` Avi Kivity
2012-04-03 9:34 ` Andreas Färber
2012-04-03 10:11 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7ACC5D.4090708@redhat.com \
--to=avi@redhat.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=anthony@codemonkey.ws \
--cc=julian.pidancet@citrix.com \
--cc=julien.grall@citrix.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).