From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48516) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SF0gO-00084y-8z for qemu-devel@nongnu.org; Tue, 03 Apr 2012 06:09:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SF0gI-0001NH-31 for qemu-devel@nongnu.org; Tue, 03 Apr 2012 06:09:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11436) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SF0gH-0001Lm-Qo for qemu-devel@nongnu.org; Tue, 03 Apr 2012 06:09:42 -0400 Message-ID: <4F7ACC5D.4090708@redhat.com> Date: Tue, 03 Apr 2012 13:09:33 +0300 From: Avi Kivity MIME-Version: 1.0 References: <4F7AAC02.6090606@redhat.com> <4F7AC4FB.2070702@citrix.com> In-Reply-To: <4F7AC4FB.2070702@citrix.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Memory: unify ioport registration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Julien Grall Cc: Julian Pidancet , "qemu-devel@nongnu.org" , Anthony Liguori , Stefano Stabellini On 04/03/2012 12:38 PM, Julien Grall wrote: >> Please pass either pci_address_space_io() or isa_io_address_space() >> (you'll have to write the latter) to cirrus_init_common() from its >> callers. We really want to avoid get_system_io(). >> >> > isa_io_address_space doesn't exist. I will create it, but which > memory region we need to return ? get_system_io () ? > Yes. The point it that we can later remove that get_system_io() in one place, instead of many. Please add isa_io_address_space() in a separate patch. -- error compiling committee.c: too many arguments to function