qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Julien Grall <julien.grall@citrix.com>,
	stefano.stabellini@eu.citrix.com, qemu-devel@nongnu.org,
	julian.pidancet@citrix.com
Subject: Re: [Qemu-devel] [PATCH] Memory: unify ioport registration
Date: Tue, 03 Apr 2012 13:11:40 +0300	[thread overview]
Message-ID: <4F7ACCDC.7010800@redhat.com> (raw)
In-Reply-To: <4F7AC42E.4040406@suse.de>

On 04/03/2012 12:34 PM, Andreas Färber wrote:
> Am 02.04.2012 16:37, schrieb Julien Grall:
> > Replace register_ioport* by portio_list_*.
> [snip]
>
> Are these changes guaranteed to not change the addresses in some way?

Yes (modulo those subtle bugs).

> We've had really subtle bugs with offsets added / not added in the past.

Those were bugs in the implementation of the portio functions and the
memory core, not the conversions IIRC.

-- 
error compiling committee.c: too many arguments to function

      reply	other threads:[~2012-04-03 10:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-02 14:37 [Qemu-devel] [PATCH] Memory: unify ioport registration Julien Grall
2012-04-03  7:51 ` Avi Kivity
2012-04-03  9:38   ` Julien Grall
2012-04-03 10:09     ` Avi Kivity
2012-04-04 15:55   ` Julien Grall
2012-04-05  9:58     ` Avi Kivity
2012-04-03  9:34 ` Andreas Färber
2012-04-03 10:11   ` Avi Kivity [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F7ACCDC.7010800@redhat.com \
    --to=avi@redhat.com \
    --cc=afaerber@suse.de \
    --cc=julian.pidancet@citrix.com \
    --cc=julien.grall@citrix.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefano.stabellini@eu.citrix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).