From: Kevin Wolf <kwolf@redhat.com>
To: Jeff Cody <jcody@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block: bdrv_append() fixes
Date: Tue, 03 Apr 2012 13:24:37 +0200 [thread overview]
Message-ID: <4F7ADDF5.1030703@redhat.com> (raw)
In-Reply-To: <888ccd7cf8f0c8ad69a34fb28785744abe85df8f.1332880179.git.jcody@redhat.com>
Am 27.03.2012 22:30, schrieb Jeff Cody:
> A few fixups for bdrv_append():
>
> The new bs (bs_new) passed into bdrv_append() should be anonymous. Rather
> than call bdrv_make_anon() to enforce this, use an assert to catch when a caller
> is passing in a bs_new that is not anonymous.
>
> Also, the new top layer should have its backing_format reflect the original
> top's format.
>
> And last, after the swap of bs contents, the device_name will have been copied
> down. This needs to be cleared to reflect the anonymity of the bs that was
> pushed down.
>
> Signed-off-by: Jeff Cody <jcody@redhat.com>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2012-04-03 11:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 20:30 [Qemu-devel] [PATCH] block: bdrv_append() fixes Jeff Cody
2012-04-03 11:24 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7ADDF5.1030703@redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=jcody@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).