From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57487)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SF1wx-0000nQ-Tm
	for qemu-devel@nongnu.org; Tue, 03 Apr 2012 07:31:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SF1ws-0007RI-3w
	for qemu-devel@nongnu.org; Tue, 03 Apr 2012 07:30:59 -0400
Received: from mail-pz0-f46.google.com ([209.85.210.46]:37802)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SF1wr-0007Ng-QI
	for qemu-devel@nongnu.org; Tue, 03 Apr 2012 07:30:54 -0400
Received: by mail-pz0-f46.google.com with SMTP id z9so4204843dad.33
	for <qemu-devel@nongnu.org>; Tue, 03 Apr 2012 04:30:52 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4F7ADF66.8070806@redhat.com>
Date: Tue, 03 Apr 2012 13:30:46 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1333442297-18932-1-git-send-email-laijs@cn.fujitsu.com>
	<1333442297-18932-2-git-send-email-laijs@cn.fujitsu.com>
In-Reply-To: <1333442297-18932-2-git-send-email-laijs@cn.fujitsu.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 02/10] coroutine: rename unlock_bh_queue to
	co_runnable_queue
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, qemu-devel@nongnu.org

Il 03/04/2012 10:38, Lai Jiangshan ha scritto:
> It stands for runnable Coroutines.
> 
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> ---
>  qemu-coroutine-lock.c |   18 +++++++++---------
>  1 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/qemu-coroutine-lock.c b/qemu-coroutine-lock.c
> index 26ad76b..10e8dbb 100644
> --- a/qemu-coroutine-lock.c
> +++ b/qemu-coroutine-lock.c
> @@ -29,17 +29,17 @@
>  #include "main-loop.h"
>  #include "trace.h"
>  
> -static QTAILQ_HEAD(, Coroutine) unlock_bh_queue =
> -    QTAILQ_HEAD_INITIALIZER(unlock_bh_queue);
> -static QEMUBH* unlock_bh;
> +static QTAILQ_HEAD(, Coroutine) co_runnable_queue =
> +    QTAILQ_HEAD_INITIALIZER(co_runnable_queue);
> +static QEMUBH* co_runnable_bh;
>  
>  static void qemu_co_queue_next_bh(void *opaque)
>  {
>      Coroutine *next;
>  
>      trace_qemu_co_queue_next_bh();
> -    while ((next = QTAILQ_FIRST(&unlock_bh_queue))) {
> -        QTAILQ_REMOVE(&unlock_bh_queue, next, co_queue_next);
> +    while ((next = QTAILQ_FIRST(&co_runnable_queue))) {
> +        QTAILQ_REMOVE(&co_runnable_queue, next, co_queue_next);
>          qemu_coroutine_enter(next, NULL);
>      }
>  }
> @@ -48,8 +48,8 @@ void qemu_co_queue_init(CoQueue *queue)
>  {
>      QTAILQ_INIT(&queue->entries);
>  
> -    if (!unlock_bh) {
> -        unlock_bh = qemu_bh_new(qemu_co_queue_next_bh, NULL);
> +    if (!co_runnable_bh) {
> +        co_runnable_bh = qemu_bh_new(qemu_co_queue_next_bh, NULL);
>      }
>  }
>  
> @@ -76,9 +76,9 @@ bool qemu_co_queue_next(CoQueue *queue)
>      next = QTAILQ_FIRST(&queue->entries);
>      if (next) {
>          QTAILQ_REMOVE(&queue->entries, next, co_queue_next);
> -        QTAILQ_INSERT_TAIL(&unlock_bh_queue, next, co_queue_next);
> +        QTAILQ_INSERT_TAIL(&co_runnable_queue, next, co_queue_next);
>          trace_qemu_co_queue_next(next);
> -        qemu_bh_schedule(unlock_bh);
> +        qemu_bh_schedule(co_runnable_bh);
>      }
>  
>      return (next != NULL);

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>