From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57527) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SF1xC-0001VU-8k for qemu-devel@nongnu.org; Tue, 03 Apr 2012 07:31:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SF1x5-0007TG-SP for qemu-devel@nongnu.org; Tue, 03 Apr 2012 07:31:13 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:37802) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SF1x5-0007Ng-Jv for qemu-devel@nongnu.org; Tue, 03 Apr 2012 07:31:07 -0400 Received: by mail-pz0-f46.google.com with SMTP id z9so4204843dad.33 for ; Tue, 03 Apr 2012 04:31:06 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4F7ADF74.9010103@redhat.com> Date: Tue, 03 Apr 2012 13:31:00 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1333442297-18932-1-git-send-email-laijs@cn.fujitsu.com> <1333442297-18932-3-git-send-email-laijs@cn.fujitsu.com> In-Reply-To: <1333442297-18932-3-git-send-email-laijs@cn.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 03/10] coroutine: rename qemu_co_queue_next_bh() to qemu_co_process_runnable() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lai Jiangshan Cc: Kevin Wolf , Anthony Liguori , Stefan Hajnoczi , qemu-devel@nongnu.org Il 03/04/2012 10:38, Lai Jiangshan ha scritto: > Signed-off-by: Lai Jiangshan > --- > qemu-coroutine-lock.c | 6 +++--- > trace-events | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/qemu-coroutine-lock.c b/qemu-coroutine-lock.c > index 10e8dbb..90141cd 100644 > --- a/qemu-coroutine-lock.c > +++ b/qemu-coroutine-lock.c > @@ -33,11 +33,11 @@ static QTAILQ_HEAD(, Coroutine) co_runnable_queue = > QTAILQ_HEAD_INITIALIZER(co_runnable_queue); > static QEMUBH* co_runnable_bh; > > -static void qemu_co_queue_next_bh(void *opaque) > +static void qemu_co_process_runnable(void *opaque) > { > Coroutine *next; > > - trace_qemu_co_queue_next_bh(); > + trace_qemu_co_process_runnable(); > while ((next = QTAILQ_FIRST(&co_runnable_queue))) { > QTAILQ_REMOVE(&co_runnable_queue, next, co_queue_next); > qemu_coroutine_enter(next, NULL); > @@ -49,7 +49,7 @@ void qemu_co_queue_init(CoQueue *queue) > QTAILQ_INIT(&queue->entries); > > if (!co_runnable_bh) { > - co_runnable_bh = qemu_bh_new(qemu_co_queue_next_bh, NULL); > + co_runnable_bh = qemu_bh_new(qemu_co_process_runnable, NULL); > } > } > > diff --git a/trace-events b/trace-events > index 70f059d..a1737c2 100644 > --- a/trace-events > +++ b/trace-events > @@ -561,7 +561,7 @@ qemu_coroutine_yield(void *from, void *to) "from %p to %p" > qemu_coroutine_terminate(void *co) "self %p" > > # qemu-coroutine-lock.c > -qemu_co_queue_next_bh(void) "" > +qemu_co_process_runnable(void) "" > qemu_co_queue_next(void *next) "next %p" > qemu_co_mutex_lock_entry(void *mutex, void *self) "mutex %p self %p" > qemu_co_mutex_lock_return(void *mutex, void *self) "mutex %p self %p" Reviewed-by: Paolo Bonzini