From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57650)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SF1xy-0003Am-Je
	for qemu-devel@nongnu.org; Tue, 03 Apr 2012 07:32:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SF1xt-0007Yo-5p
	for qemu-devel@nongnu.org; Tue, 03 Apr 2012 07:32:01 -0400
Received: from mail-pz0-f46.google.com ([209.85.210.46]:57685)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SF1xs-0007Xw-TB
	for qemu-devel@nongnu.org; Tue, 03 Apr 2012 07:31:57 -0400
Received: by dadz9 with SMTP id z9so4206197dad.33
	for <qemu-devel@nongnu.org>; Tue, 03 Apr 2012 04:31:51 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4F7ADFA1.3050501@redhat.com>
Date: Tue, 03 Apr 2012 13:31:45 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1333442297-18932-1-git-send-email-laijs@cn.fujitsu.com>
	<1333442297-18932-5-git-send-email-laijs@cn.fujitsu.com>
In-Reply-To: <1333442297-18932-5-git-send-email-laijs@cn.fujitsu.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 05/10] coroutine: add
	qemu_co_runnable_schedule()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, qemu-devel@nongnu.org

Il 03/04/2012 10:38, Lai Jiangshan ha scritto:
> split qemu_co_queue_next() as two parts:
> the first part is dequeuing next from the wait queue.
> the second part is schedule it to the runnable queue(qemu_co_runnable_schedule())
> 
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> ---
>  qemu-coroutine-lock.c |    9 +++++++--
>  1 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/qemu-coroutine-lock.c b/qemu-coroutine-lock.c
> index 7c29bc4..6f47685 100644
> --- a/qemu-coroutine-lock.c
> +++ b/qemu-coroutine-lock.c
> @@ -44,6 +44,12 @@ static void qemu_co_process_runnable(void *opaque)
>      }
>  }
>  
> +static void qemu_co_runnable_schedule(Coroutine *co)
> +{
> +    QTAILQ_INSERT_TAIL(&co_runnable_queue, co, co_queue_next);
> +    qemu_bh_schedule(co_runnable_bh);
> +}
> +
>  static void __attribute__((constructor)) co_runnable_bh_init(void)
>  {
>      co_runnable_bh = qemu_bh_new(qemu_co_process_runnable, NULL);
> @@ -77,9 +83,8 @@ bool qemu_co_queue_next(CoQueue *queue)
>      next = QTAILQ_FIRST(&queue->entries);
>      if (next) {
>          QTAILQ_REMOVE(&queue->entries, next, co_queue_next);
> -        QTAILQ_INSERT_TAIL(&co_runnable_queue, next, co_queue_next);
>          trace_qemu_co_queue_next(next);
> -        qemu_bh_schedule(co_runnable_bh);
> +        qemu_co_runnable_schedule(next);
>      }
>  
>      return (next != NULL);

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>