From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40690) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SF29H-0001jA-3s for qemu-devel@nongnu.org; Tue, 03 Apr 2012 07:43:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SF29F-0002ba-Cw for qemu-devel@nongnu.org; Tue, 03 Apr 2012 07:43:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37089) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SF29F-0002bR-4Z for qemu-devel@nongnu.org; Tue, 03 Apr 2012 07:43:41 -0400 Message-ID: <4F7AE342.5070407@redhat.com> Date: Tue, 03 Apr 2012 13:47:14 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1333442297-18932-1-git-send-email-laijs@cn.fujitsu.com> <1333442297-18932-7-git-send-email-laijs@cn.fujitsu.com> In-Reply-To: <1333442297-18932-7-git-send-email-laijs@cn.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 07/10] coroutine: split qemu-coroutine-lock.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lai Jiangshan Cc: Anthony Liguori , Stefan Hajnoczi , qemu-devel@nongnu.org Am 03.04.2012 10:38, schrieb Lai Jiangshan: > queues are not just internal things for locks, split them. > > Signed-off-by: Lai Jiangshan > --- > Makefile.objs | 2 +- > qemu-coroutine-lock.c | 49 +------------------------------ > qemu-coroutine-queue.c | 76 ++++++++++++++++++++++++++++++++++++++++++++++++ > trace-events | 4 ++- > 4 files changed, 81 insertions(+), 50 deletions(-) What's the point? qemu-coroutine-lock.c is already a small file (171 lines) and all functions in it are doing related things (they synchronise coroutines). Splitting a small cohesive file into two tiny halves isn't an improvement, IMO. Kevin