From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33253) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SF2aI-0005dK-Md for qemu-devel@nongnu.org; Tue, 03 Apr 2012 08:11:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SF2aG-0002MJ-CP for qemu-devel@nongnu.org; Tue, 03 Apr 2012 08:11:38 -0400 Received: from cantor2.suse.de ([195.135.220.15]:42934 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SF2aG-0002M7-3Z for qemu-devel@nongnu.org; Tue, 03 Apr 2012 08:11:36 -0400 Message-ID: <4F7AE8F5.50508@suse.de> Date: Tue, 03 Apr 2012 14:11:33 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1333451753-3550-1-git-send-email-pbonzini@redhat.com> <1333451753-3550-24-git-send-email-pbonzini@redhat.com> In-Reply-To: <1333451753-3550-24-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 23/25] qom: add realized property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org Paolo, Am 03.04.2012 13:15, schrieb Paolo Bonzini: > Since we had to move the state field from DeviceState to Object, we can= not > delay the implementation of the "realized" property. The property is > a trigger for two actions that propagate through the composition tree. > "Realize" is called when the property becomes true, and propagates in > pre-order; realize can fail if the values of the properties are not val= id. > "Unrealize" is called when the property becomes false, and propagates i= n > post-order; unrealize cannot fail. >=20 > Unrealize is also called by object_deinit, as a separate step before > finalization. >=20 > Realize/unrealize is separate from reset. Reset propagation is a thorn= y > issue of its own. We expect classes that care to implement a reset met= hod > and call it from realize or realize_children, depending on whether > pre-order or post-order is more appropriate. >=20 > This patch adds four methods (realize, realize_children, unrealize, > unrealize_children) to ObjectClass, together with a default implementat= ion > of realize_children and unrealize_children. >=20 > Signed-off-by: Paolo Bonzini Since this patch is clearly an extended version of my realize patch http://patchwork.ozlabs.org/patch/148752/, it should carry my SoB, as reminded last night. If you don't want my SoB on the parts I didn't do - namely unrealize and *_childen - then feel free to split the patch in two. Simply dropping attribution in both cover letter and commit just because I didn't get around yet to sending a v2 with those requests addressed is not nice! Patch 24/25 was done differently (calling realized =3D true from init rather than the other way around) so this comment only applies to 23/25. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg