From: Kevin Wolf <kwolf@redhat.com>
To: Zhi Hui Li <zhihuili@linux.vnet.ibm.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
zhihuili@cn.ibm.com, QEMU-devel <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] Replace bdrv_* to bdrv_aio_* functions in pio mode in fdc.c.
Date: Tue, 03 Apr 2012 14:29:20 +0200 [thread overview]
Message-ID: <4F7AED20.3020208@redhat.com> (raw)
In-Reply-To: <4F7AE57F.8020802@linux.vnet.ibm.com>
Am 03.04.2012 13:56, schrieb Zhi Hui Li:
> On 2012年04月02日 20:07, Stefan Hajnoczi wrote:
>> On Sat, Mar 31, 2012 at 09:15:10PM +0800, Li Zhi Hui wrote:
>>> Replace bdrv_* to bdrv_aio_* functions in pio mode in fdc.c.
>>>
>>> Signed-off-by: Li Zhi Hui<zhihuili@linux.vnet.ibm.com>
>>> ---
>>> hw/fdc.c | 123 +++++++++++++++++++++++++++++++++++++++++++++-----------------
>>> 1 files changed, 89 insertions(+), 34 deletions(-)
>>
>> How can I test this patch?
>>
>> Stefan
>>
>
> sorry, I don't find a good way to test it directly.
>
> but I have read the datasheet of floppy, I modify it according to the
> datasheet.
How about adding some qtest-based test cases for floppy? It's one of the
devices that I usually don't test manually, so having an automated test
would be good anyway.
Kevin
prev parent reply other threads:[~2012-04-03 12:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-31 13:15 [Qemu-devel] [PATCH v2] Replace bdrv_* to bdrv_aio_* functions in pio mode in fdc.c Li Zhi Hui
2012-04-02 12:07 ` Stefan Hajnoczi
2012-04-02 13:08 ` Paolo Bonzini
2012-04-03 15:33 ` Stefan Hajnoczi
2012-04-03 15:34 ` Stefan Hajnoczi
2012-04-03 11:56 ` Zhi Hui Li
2012-04-03 12:29 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7AED20.3020208@redhat.com \
--to=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=zhihuili@cn.ibm.com \
--cc=zhihuili@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).