From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:43412)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SF2oW-00049p-1h
	for qemu-devel@nongnu.org; Tue, 03 Apr 2012 08:26:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SF2oP-0006Dv-QM
	for qemu-devel@nongnu.org; Tue, 03 Apr 2012 08:26:19 -0400
Received: from mx1.redhat.com ([209.132.183.28]:11728)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SF2oP-0006Dg-II
	for qemu-devel@nongnu.org; Tue, 03 Apr 2012 08:26:13 -0400
Message-ID: <4F7AED20.3020208@redhat.com>
Date: Tue, 03 Apr 2012 14:29:20 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1333199710-9061-1-git-send-email-zhihuili@linux.vnet.ibm.com>
	<20120402120745.GA23753@stefanha-thinkpad.localdomain>
	<4F7AE57F.8020802@linux.vnet.ibm.com>
In-Reply-To: <4F7AE57F.8020802@linux.vnet.ibm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2] Replace bdrv_* to bdrv_aio_* functions
 in pio mode in fdc.c.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Zhi Hui Li <zhihuili@linux.vnet.ibm.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, zhihuili@cn.ibm.com, QEMU-devel <qemu-devel@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>

Am 03.04.2012 13:56, schrieb Zhi Hui Li:
> On 2012=E5=B9=B404=E6=9C=8802=E6=97=A5 20:07, Stefan Hajnoczi wrote:
>> On Sat, Mar 31, 2012 at 09:15:10PM +0800, Li Zhi Hui wrote:
>>> Replace bdrv_* to bdrv_aio_* functions in pio mode in fdc.c.
>>>
>>> Signed-off-by: Li Zhi Hui<zhihuili@linux.vnet.ibm.com>
>>> ---
>>>   hw/fdc.c |  123 +++++++++++++++++++++++++++++++++++++++++++++------=
-----------
>>>   1 files changed, 89 insertions(+), 34 deletions(-)
>>
>> How can I test this patch?
>>
>> Stefan
>>
>=20
> sorry, I don't find a good way to test it directly.
>=20
> but I have read the datasheet of floppy, I modify it according to the=20
> datasheet.

How about adding some qtest-based test cases for floppy? It's one of the
devices that I usually don't test manually, so having an automated test
would be good anyway.

Kevin