From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFAvc-000102-LZ for qemu-devel@nongnu.org; Tue, 03 Apr 2012 17:06:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SFAva-0001ik-SH for qemu-devel@nongnu.org; Tue, 03 Apr 2012 17:06:12 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:35788) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFAva-0001id-NV for qemu-devel@nongnu.org; Tue, 03 Apr 2012 17:06:10 -0400 Received: by obbup19 with SMTP id up19so196679obb.4 for ; Tue, 03 Apr 2012 14:06:09 -0700 (PDT) Message-ID: <4F7B663E.5020207@codemonkey.ws> Date: Tue, 03 Apr 2012 16:06:06 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1333451753-3550-1-git-send-email-pbonzini@redhat.com> <1333451753-3550-8-git-send-email-pbonzini@redhat.com> In-Reply-To: <1333451753-3550-8-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 07/25] qdev: use object_property_print in info qtree List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aliguori@us.ibm.com, Jan Kiszka , qemu-devel@nongnu.org, afaerber@suse.de On 04/03/2012 06:15 AM, Paolo Bonzini wrote: > Otherwise, non-string properties without a legacy counterpart are missed. > Also fix error propagation in object_property_print itself, otherwise > pointer properties are printed as "". > > Signed-off-by: Paolo Bonzini Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > hw/qdev-monitor.c | 2 +- > qom/object.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c > index 0acfc82..07ac525 100644 > --- a/hw/qdev-monitor.c > +++ b/hw/qdev-monitor.c > @@ -492,7 +492,7 @@ static void qdev_print_props(Monitor *mon, DeviceState *dev, Property *props, > if (object_property_get_type(OBJECT(dev), legacy_name, NULL)) { > value = object_property_get_str(OBJECT(dev), legacy_name,&err); > } else { > - value = object_property_get_str(OBJECT(dev), props->name,&err); > + value = object_property_print(OBJECT(dev), props->name,&err); > } > g_free(legacy_name); > > diff --git a/qom/object.c b/qom/object.c > index f3ffaa6..ff36946 100644 > --- a/qom/object.c > +++ b/qom/object.c > @@ -850,7 +850,7 @@ char *object_property_print(Object *obj, const char *name, > char *string; > > mo = string_output_visitor_new(); > - object_property_get(obj, string_output_get_visitor(mo), name, NULL); > + object_property_get(obj, string_output_get_visitor(mo), name, errp); > string = string_output_get_string(mo); > string_output_visitor_cleanup(mo); > return string;