From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40615) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFAz8-0002dC-Ny for qemu-devel@nongnu.org; Tue, 03 Apr 2012 17:09:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SFAz1-0002Uo-1d for qemu-devel@nongnu.org; Tue, 03 Apr 2012 17:09:49 -0400 Received: from mail-gy0-f173.google.com ([209.85.160.173]:42256) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFAz0-0002TG-TL for qemu-devel@nongnu.org; Tue, 03 Apr 2012 17:09:42 -0400 Received: by ghrr14 with SMTP id r14so121169ghr.4 for ; Tue, 03 Apr 2012 14:09:41 -0700 (PDT) Message-ID: <4F7B6712.3050209@codemonkey.ws> Date: Tue, 03 Apr 2012 16:09:38 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1333451753-3550-1-git-send-email-pbonzini@redhat.com> <1333451753-3550-9-git-send-email-pbonzini@redhat.com> In-Reply-To: <1333451753-3550-9-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 08/25] qdev: remove qdev_prop_set_defaults List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, afaerber@suse.de On 04/03/2012 06:15 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > hw/qdev-properties.c | 22 ---------------------- > hw/qdev.c | 28 +++++++++++++++++++++++----- > hw/qdev.h | 1 - > 3 files changed, 23 insertions(+), 28 deletions(-) > > diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c > index bff9152..85897c7 100644 > --- a/hw/qdev-properties.c > +++ b/hw/qdev-properties.c > @@ -1083,28 +1083,6 @@ void qdev_prop_set_ptr(DeviceState *dev, const char *name, void *value) > *ptr = value; > } > > -void qdev_prop_set_defaults(DeviceState *dev, Property *props) > -{ > - Object *obj = OBJECT(dev); > - if (!props) > - return; > - for (; props->name; props++) { > - Error *errp = NULL; > - if (props->qtype == QTYPE_NONE) { > - continue; > - } > - if (props->qtype == QTYPE_QBOOL) { > - object_property_set_bool(obj, props->defval, props->name,&errp); > - } else if (props->info->enum_table) { > - object_property_set_str(obj, props->info->enum_table[props->defval], > - props->name,&errp); > - } else if (props->qtype == QTYPE_QINT) { > - object_property_set_int(obj, props->defval, props->name,&errp); > - } > - assert_no_error(errp); > - } > -} > - > static QTAILQ_HEAD(, GlobalProperty) global_props = QTAILQ_HEAD_INITIALIZER(global_props); > > static void qdev_prop_register_global(GlobalProperty *prop) > diff --git a/hw/qdev.c b/hw/qdev.c > index bb6c1aa..4ac5616 100644 > --- a/hw/qdev.c > +++ b/hw/qdev.c > @@ -90,7 +90,6 @@ void qdev_set_parent_bus(DeviceState *dev, BusState *bus) > qdev_property_add_legacy(dev, prop, NULL); > qdev_property_add_static(dev, prop, NULL); > } > - qdev_prop_set_defaults(dev, dev->parent_bus->info->props); Does this break bisectability? Regards, Anthony Liguori