From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42391) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFLuS-0000Ym-Fy for qemu-devel@nongnu.org; Wed, 04 Apr 2012 04:49:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SFLuL-0001in-98 for qemu-devel@nongnu.org; Wed, 04 Apr 2012 04:49:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30005) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFLuL-0001gU-0z for qemu-devel@nongnu.org; Wed, 04 Apr 2012 04:49:37 -0400 Message-ID: <4F7C0BF6.6050404@redhat.com> Date: Wed, 04 Apr 2012 10:53:10 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <4F7AD149.5030006@redhat.com> <1333483438-8431-1-git-send-email-namei.unix@gmail.com> In-Reply-To: <1333483438-8431-1-git-send-email-namei.unix@gmail.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5] sheepdog: implement SD_OP_FLUSH_VDI operation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liu Yuan Cc: qemu-devel@nongnu.org, MORITA Kazutaka Am 03.04.2012 22:03, schrieb Liu Yuan: > From: Liu Yuan > > Flush operation is supposed to flush the write-back cache of > sheepdog cluster. > > By issuing flush operation, we can assure the Guest of data > reaching the sheepdog cluster storage. > > Cc: Kevin Wolf > Cc: MORITA Kazutaka > Signed-off-by: Liu Yuan > --- > Hi Kevin, > Sorry, I found a problem in v4 patch, that s->{addr, port} isn't properly > initilized. > If you think it is inconvenient for you to update this patch, please let > me know and I'll submit a new patch. I can update it in my queue, no problem there. But I diffed this against v4 and it doesn't seem to have any changes, except in the context of two hunks. Are you sure that you didn't do the fixes in a separate commit or send the wrong patch or something like that? Kevin