From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41222)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SFMKO-0005lm-Q5
	for qemu-devel@nongnu.org; Wed, 04 Apr 2012 05:16:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SFMKN-00008V-3i
	for qemu-devel@nongnu.org; Wed, 04 Apr 2012 05:16:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:30117)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SFMKM-000088-Sh
	for qemu-devel@nongnu.org; Wed, 04 Apr 2012 05:16:31 -0400
Message-ID: <4F7C1244.1060304@redhat.com>
Date: Wed, 04 Apr 2012 11:20:04 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <4F7AD149.5030006@redhat.com>
	<1333483438-8431-1-git-send-email-namei.unix@gmail.com>
	<4F7C0BF6.6050404@redhat.com> <4F7C0D44.4060808@gmail.com>
In-Reply-To: <4F7C0D44.4060808@gmail.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5] sheepdog: implement SD_OP_FLUSH_VDI
	operation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Liu Yuan <namei.unix@gmail.com>
Cc: qemu-devel@nongnu.org, MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>

Am 04.04.2012 10:58, schrieb Liu Yuan:
> Hi kevin,
> 
> On 04/04/2012 04:53 PM, Kevin Wolf wrote:
> 
>> I can update it in my queue, no problem there.
>>
>> But I diffed this against v4 and it doesn't seem to have any changes,
>> except in the context of two hunks. Are you sure that you didn't do the
>> fixes in a separate commit or send the wrong patch or something like that?
> 
> 
> V5 patch just reordered some of lines in sd_open() see below:
> [...]
> 
> s->{addr,port} is initilized in find_vdi_name(), so flush_fd should be
> initilized after it.

Yes, of course. It seems to be still too early in the morning...

Thanks, I updated the patch in my queue.

Kevin