From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFS5h-0003H3-2l for qemu-devel@nongnu.org; Wed, 04 Apr 2012 11:25:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SFS5Y-0003b2-UA for qemu-devel@nongnu.org; Wed, 04 Apr 2012 11:25:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14617) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFS5Y-0003a6-Lw for qemu-devel@nongnu.org; Wed, 04 Apr 2012 11:25:36 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q34FPTX0010880 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 4 Apr 2012 11:25:30 -0400 Message-ID: <4F7C67E8.9070408@redhat.com> Date: Wed, 04 Apr 2012 17:25:28 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1333128782-20589-1-git-send-email-ehabkost@redhat.com> In-Reply-To: <1333128782-20589-1-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/14] configure: --with-confsuffix option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org Il 30/03/2012 19:32, Eduardo Habkost ha scritto: > This series is the third version of the --confsuffix/--confdir changes I have > submitted before. Now it does two interface changes: > > - Changes --datadir meaning to match Autoconf convention > (meaning that it should point to /usr/share, not /usr/share/qemu). > NOTE: this breaks compatibility. > I don't know of anybody who uses that option today. Neither Fedora, Debian, > Arch Linux, Gentoo, or FreeBSD use it[1]. > - Add --with-confsuffix option, to allow the /etc/qemu and /usr/share/qemu > directories to have a different names. > > [1] http://article.gmane.org/gmane.comp.emulators.qemu/142924 > > Most of the patches are variable renames and cleanups. The actual changes are > only on the last 2 patches. > > First, internal configure variables are renamed, without changing > config-host.mak: > > configure: rename $datadir to $qemu_datadir > configure: rename $docdir to $qemu_docdir > configure: rename $confdir to $qemu_confdir > > Then create_config gets ready for config-host.mak variable renames > (Qemu-specific directories will now have a "qemu_" prefix): > > create_config: separate section for qemu_*dir variables > > Then, variables are renamed on config-host.mak and Makefiles: > > config-host.mak: rename datadir to qemu_datadir > config-host.mak: rename confdir to qemu_confdir > Makefile: use $(qemu_confdir) instead of $(sysconfdir)/qemu > config-host.mak: rename docdir to qemu_docdir > config-host.mak: remove CONFIG_QEMU_SHAREDIR > config-host.mak: reorder variables a bit > > Then old code on create_config is removed: > > create_config: remove *dir block > create_config: simplify prefix=* block, remove CONFIG_QEMU_PREFIX > > Finally, the user-visible changes: > > configure: change meaning of --datadir to Autoconf convention > configure: add --confsuffix option > > > > Eduardo Habkost (14): > configure: rename $datadir to $qemu_datadir > configure: rename $docdir to $qemu_docdir > configure: rename $confdir to $qemu_confdir > create_config: separate section for qemu_*dir variables > config-host.mak: rename datadir to qemu_datadir > config-host.mak: rename confdir to qemu_confdir > Makefile: use $(qemu_confdir) instead of $(sysconfdir)/qemu > config-host.mak: rename docdir to qemu_docdir > config-host.mak: remove CONFIG_QEMU_SHAREDIR > config-host.mak: reorder variables a bit > create_config: remove *dir block > create_config: simplify prefix=* block, remove CONFIG_QEMU_PREFIX > configure: change meaning of --datadir to Autoconf convention > configure: add --confsuffix option > > Makefile | 16 ++++++++-------- > Makefile.target | 4 ++-- > configure | 29 ++++++++++++++++------------- > scripts/create_config | 8 ++++++-- > 4 files changed, 32 insertions(+), 25 deletions(-) > Reviewed-by: Paolo Bonzini