From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38144) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFSIJ-0001aW-Bc for qemu-devel@nongnu.org; Wed, 04 Apr 2012 11:38:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SFSIB-00073c-4G for qemu-devel@nongnu.org; Wed, 04 Apr 2012 11:38:45 -0400 Received: from thoth.sbs.de ([192.35.17.2]:15062) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFSIA-00072g-Qo for qemu-devel@nongnu.org; Wed, 04 Apr 2012 11:38:39 -0400 Message-ID: <4F7C6AF9.7080605@siemens.com> Date: Wed, 04 Apr 2012 17:38:33 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4F7C663E.20200@redhat.com> <4F7C67BA.4000007@siemens.com> <4F7C68E2.508@redhat.com> In-Reply-To: <4F7C68E2.508@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Kevin Wolf , Anthony Liguori , "qemu-devel@nongnu.org" On 2012-04-04 17:29, Paolo Bonzini wrote: > Il 04/04/2012 17:24, Jan Kiszka ha scritto: >>>> For patches 3 and 4, I'd rather use an EventNotifier... >> ...which still lacks support for non-eventfd systems. Hmm, I guess it's >> time to consolidate both. > > Perhaps you can take the relevant patches out of the thread-blocks > branch at git://github.com/pbonzini/qemu.git? The iothread eventfd > could also use an EventNotifier. Current EventNotifier code applies EFD_SEMAPHORE, which is not what we want for Posix AIO (otherwise we could just stick with the pipe). I cannot match the reasoning for EFD_SEM in event_notifier.c with the man page, need to dig deeper. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux