From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35839) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFh7S-00029H-NT for qemu-devel@nongnu.org; Thu, 05 Apr 2012 03:28:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SFh7M-00062Q-50 for qemu-devel@nongnu.org; Thu, 05 Apr 2012 03:28:34 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34238 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFh7L-00062D-Rp for qemu-devel@nongnu.org; Thu, 05 Apr 2012 03:28:28 -0400 Message-ID: <4F7D4998.8000000@suse.de> Date: Thu, 05 Apr 2012 09:28:24 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <20120403173224.GA22140@aepfle.de> <20348.26046.686582.18393@mariner.uk.xensource.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Xen-devel] [PATCH v2] qemu/configure: fix CFLAGS handling for i386 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Olaf Hering Cc: Peter Maydell , "xen-devel@lists.xensource.com Devel" , Ian Jackson , qemu-devel@nongnu.org Am 04.04.2012 18:09, schrieb Peter Maydell: > On 4 April 2012 16:40, Peter Maydell wrote: >> Having looked at configure I'm pretty sure what we want here is >> QEMU_CFLAGS=3D"-march=3Di486 $QEMU_CFLAGS" >> >> because we're only doing this for the benefit of a particular bit >> of code in hw/vhost.c and so QEMU_CFLAGS is sufficient. Also this >> brings it into line with other places where we add a -march flag, >> which use QEMU_CFLAGS, not CFLAGS. >=20 > ...and having dug around in the git history we find that QEMU_CFLAGS > were introduced in commit a558ee1, whose commit message defines the > difference like this: > QEMU_CFLAGS: flags without which we can't compile > CFLAGS: "-g -O2" >=20 > "-march=3Di486" is clearly "flags without which we can't compile", > so we should be setting it in QEMU_CFLAGS, not CFLAGS. >=20 > Olaf, if you want to submit a fixed patch I think we should apply > it to upstream qemu. >=20 > PS: remarks like > "This patch is against the qemu-xen tree, but it should apply also to > qemu.git since it has the same issue. Please apply to both trees." >=20 > should go below the '---' in a patch email so they don't appear > in the git commit message when the patch is applied. And you also forgot to update the subject to something like: "configure: Fix CFLAGS handling for i386" - this is for the QEMU repository after all, so no need to put that into the commit message. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg