From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41500) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFlx0-00048e-5R for qemu-devel@nongnu.org; Thu, 05 Apr 2012 08:38:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SFlwt-0008Kb-Tg for qemu-devel@nongnu.org; Thu, 05 Apr 2012 08:38:05 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:33763) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFlwt-0008KO-HT for qemu-devel@nongnu.org; Thu, 05 Apr 2012 08:37:59 -0400 Received: by dadz9 with SMTP id z9so1885689dad.33 for ; Thu, 05 Apr 2012 05:37:57 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4F7D921E.9040003@redhat.com> Date: Thu, 05 Apr 2012 14:37:50 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <6e10c02cbb87fe30703de848455593df41ec7f4b.1333623555.git.jan.kiszka@siemens.com> <4F7D887B.1030104@siemens.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 01/10] Introduce qemu_cond_timedwait for POSIX List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: Kevin Wolf , Jan Kiszka , Anthony Liguori , "qemu-devel@nongnu.org" , Peter Maydell Il 05/04/2012 14:30, malc ha scritto: >> > Would save that "* 1000". I just wondered why we do not use it elsewhere >> > in QEMU and was reluctant to risk some BSD breakage. >> > > It's probably worth mentioning that using anything other than > clock_gettime and CLOCK_MONOTONING (as well as setting proper pthread > clock attr on the condition variable) is prone to the surprises (such > as NTP corrections and daylight saving changes). I was about to suggest the same, but how widespread is support for pthread_condattr_setclock? Paolo