From: Kevin Wolf <kwolf@redhat.com>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 08/10] coroutine: process the coroutines woken by child when child yield
Date: Thu, 05 Apr 2012 14:43:04 +0200 [thread overview]
Message-ID: <4F7D9358.4040700@redhat.com> (raw)
In-Reply-To: <1333442297-18932-8-git-send-email-laijs@cn.fujitsu.com>
Am 03.04.2012 10:38, schrieb Lai Jiangshan:
> If the child wake up someone, process them.
>
> It would the child complete its works if woken coroutine release the locks
> that the child needs.
>
> It may help for the cache, if the child wake up some someone, they are
> probably accessing the same data.
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Are you very sure that this is correct, particularly with respect to
reentrancy of nested coroutines? This is why this has become a bottom
half in the first place (instead of directly reentering the unlocked
coroutine in qemu_co_mutex_unlock), and it's not completely clear to me
if the problem doesn't exist when you do it after a coroutine has exited
instead of in an BH.
I'd be very careful with such changes.
Kevin
next prev parent reply other threads:[~2012-04-05 13:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 8:38 [Qemu-devel] [PATCH 01/10] coroutine: use qemu_coroutine_switch() directly Lai Jiangshan
2012-04-03 8:38 ` [Qemu-devel] [PATCH 02/10] coroutine: rename unlock_bh_queue to co_runnable_queue Lai Jiangshan
2012-04-03 11:30 ` Paolo Bonzini
2012-04-03 8:38 ` [Qemu-devel] [PATCH 03/10] coroutine: rename qemu_co_queue_next_bh() to qemu_co_process_runnable() Lai Jiangshan
2012-04-03 11:31 ` Paolo Bonzini
2012-04-03 11:43 ` Kevin Wolf
2012-04-03 8:38 ` [Qemu-devel] [PATCH 04/10] coroutine: init co_runnable_bh during boot Lai Jiangshan
2012-04-03 11:31 ` Paolo Bonzini
2012-04-03 8:38 ` [Qemu-devel] [PATCH 05/10] coroutine: add qemu_co_runnable_schedule() Lai Jiangshan
2012-04-03 11:31 ` Paolo Bonzini
2012-04-03 8:38 ` [Qemu-devel] [PATCH 06/10] coroutine: move runnale coroutine code to qemu-coroutine.c Lai Jiangshan
2012-04-03 11:32 ` Paolo Bonzini
2012-04-03 8:38 ` [Qemu-devel] [PATCH 07/10] coroutine: split qemu-coroutine-lock.c Lai Jiangshan
2012-04-03 11:32 ` Paolo Bonzini
2012-04-03 11:47 ` Kevin Wolf
2012-04-03 8:38 ` [Qemu-devel] [PATCH 08/10] coroutine: process the coroutines woken by child when child yield Lai Jiangshan
2012-04-05 12:43 ` Kevin Wolf [this message]
2012-04-03 8:38 ` [Qemu-devel] [PATCH 09/10] coroutine: schedule timeout coroutine instead process it directly Lai Jiangshan
2012-04-03 11:26 ` Paolo Bonzini
2012-04-03 8:38 ` [Qemu-devel] [PATCH 10/10] coroutine: add qemu_coroutine_run() wrapper Lai Jiangshan
2012-04-03 11:33 ` Paolo Bonzini
2012-04-03 11:30 ` [Qemu-devel] [PATCH 01/10] coroutine: use qemu_coroutine_switch() directly Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7D9358.4040700@redhat.com \
--to=kwolf@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=laijs@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).