From: "Andreas Färber" <afaerber@suse.de>
To: Stefan Weil <sw@weilnetz.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Benoit Canet <benoit.canet@gmail.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] sdl: Add QEMU mascot icon for use with SDL
Date: Tue, 01 May 2012 13:19:16 +0200 [thread overview]
Message-ID: <4F9FC6B4.80802@suse.de> (raw)
In-Reply-To: <4F95B77D.2020208@weilnetz.de>
Am 23.04.2012 22:11, schrieb Stefan Weil:
> Am 13.04.2012 22:24, schrieb Stefan Weil:
>> This is a bitmap file (32x32x4) derived from the official QEMU mascot
>> (which was designed by Benoît Canet). I stripped the text from the SVG
>> to get a nearly square image and converted the result to BMP without
>> any manual optimization.
>>
>> The bitmap is currently used by QEMU's SDL interface and replaces the
>> default X icon.
>>
>> v2: Add qemu-icon.bmp to Makefile.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> ---
>> Makefile | 1 +
>> pc-bios/qemu-icon.bmp | Bin 0 -> 630 bytes
>> 2 files changed, 1 insertions(+), 0 deletions(-)
>> create mode 100644 pc-bios/qemu-icon.bmp
[...]
> I'm a bit surprised that there was no reaction on this patch
> (neither on version 1 nor on version 2).
It looks kind of ugly in GNOME3, where it is scaled up to some other
resolution in the top bar. IIRC Windows 7 uses 64x64 max, Mac OS X
128x128 max, GNOME 48x48(?).
When we add icons for Gtk+ and Cocoa we might also want to rename the
file to indicate size and/or purpose (e.g., qemu-sdl-icon.bmp /
qemu-32x32-icon.bmp).
For Windows, wouldn't it be a better idea to use the multi-resolution
.ico format through version.rc and to avoid the generic SDL icon being
used? Don't see that being set up in this patch - #ifdef it out there?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next parent reply other threads:[~2012-05-01 11:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1334348682-25458-1-git-send-email-sw@weilnetz.de>
[not found] ` <4F95B77D.2020208@weilnetz.de>
2012-05-01 11:19 ` Andreas Färber [this message]
2012-05-01 16:10 ` [Qemu-devel] [PATCH v2] sdl: Add QEMU mascot icon for use with SDL Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9FC6B4.80802@suse.de \
--to=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=benoit.canet@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).