From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55340) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPB7g-0002PX-L8 for qemu-devel@nongnu.org; Tue, 01 May 2012 07:20:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SPB75-0001IZ-6j for qemu-devel@nongnu.org; Tue, 01 May 2012 07:20:00 -0400 Received: from cantor2.suse.de ([195.135.220.15]:43804 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPB75-0001Hy-04 for qemu-devel@nongnu.org; Tue, 01 May 2012 07:19:23 -0400 Message-ID: <4F9FC6B4.80802@suse.de> Date: Tue, 01 May 2012 13:19:16 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1334348682-25458-1-git-send-email-sw@weilnetz.de> <4F95B77D.2020208@weilnetz.de> In-Reply-To: <4F95B77D.2020208@weilnetz.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] sdl: Add QEMU mascot icon for use with SDL List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Anthony Liguori , Benoit Canet , qemu-devel@nongnu.org Am 23.04.2012 22:11, schrieb Stefan Weil: > Am 13.04.2012 22:24, schrieb Stefan Weil: >> This is a bitmap file (32x32x4) derived from the official QEMU mascot >> (which was designed by Beno=C3=AEt Canet). I stripped the text from th= e SVG >> to get a nearly square image and converted the result to BMP without >> any manual optimization. >> >> The bitmap is currently used by QEMU's SDL interface and replaces the >> default X icon. >> >> v2: Add qemu-icon.bmp to Makefile. >> >> Signed-off-by: Stefan Weil >> --- >> Makefile | 1 + >> pc-bios/qemu-icon.bmp | Bin 0 -> 630 bytes >> 2 files changed, 1 insertions(+), 0 deletions(-) >> create mode 100644 pc-bios/qemu-icon.bmp [...] > I'm a bit surprised that there was no reaction on this patch > (neither on version 1 nor on version 2). It looks kind of ugly in GNOME3, where it is scaled up to some other resolution in the top bar. IIRC Windows 7 uses 64x64 max, Mac OS X 128x128 max, GNOME 48x48(?). When we add icons for Gtk+ and Cocoa we might also want to rename the file to indicate size and/or purpose (e.g., qemu-sdl-icon.bmp / qemu-32x32-icon.bmp). For Windows, wouldn't it be a better idea to use the multi-resolution .ico format through version.rc and to avoid the generic SDL icon being used? Don't see that being set up in this patch - #ifdef it out there? Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg