From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58692) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPDdb-00019U-Sb for qemu-devel@nongnu.org; Tue, 01 May 2012 10:01:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SPDda-0002OG-1G for qemu-devel@nongnu.org; Tue, 01 May 2012 10:01:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10278) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPDdZ-0002OC-P8 for qemu-devel@nongnu.org; Tue, 01 May 2012 10:01:05 -0400 Message-ID: <4F9FEC9B.3010603@redhat.com> Date: Tue, 01 May 2012 16:00:59 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1335851588-21011-1-git-send-email-sw@weilnetz.de> In-Reply-To: <1335851588-21011-1-git-send-email-sw@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] sdl: Avoid unnecessary resizing of the display surface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Anthony Liguori , qemu-devel@nongnu.org Il 01/05/2012 07:53, Stefan Weil ha scritto: > If neither width nor height changes, nothing has to be done. > > Cc: Anthony Liguori > Signed-off-by: Stefan Weil > --- > > This patch improves SDL for any host (for example with remote X displays), > but the main reason why I wrote it was another problem: > > On w32 / w64 hosts, qemu-system-arm has a deadlock when it calls > sdl_resize_displaysurface during Linux boot. One thread waits for > a critical region, another thread waits inside SDL_SetVideoMode. > > The patch avoids this problem. Paolo, maybe you have an idea what > could cause the deadlock. No idea---honestly, my w32 interest is limited to replacing hacks with proper solutions. :) It turns out that in many cases you can fix bugs along the way and that helps having people look at your patches... Paolo