From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34251) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPFen-0003Ly-3d for qemu-devel@nongnu.org; Tue, 01 May 2012 12:10:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SPFek-0007pH-Aw for qemu-devel@nongnu.org; Tue, 01 May 2012 12:10:28 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:56537) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPFek-0007oo-4n for qemu-devel@nongnu.org; Tue, 01 May 2012 12:10:26 -0400 Message-ID: <4FA00AEE.1070202@weilnetz.de> Date: Tue, 01 May 2012 18:10:22 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1334348682-25458-1-git-send-email-sw@weilnetz.de> <4F95B77D.2020208@weilnetz.de> <4F9FC6B4.80802@suse.de> In-Reply-To: <4F9FC6B4.80802@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] sdl: Add QEMU mascot icon for use with SDL List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: Anthony Liguori , Benoit Canet , qemu-devel@nongnu.org Am 01.05.2012 13:19, schrieb Andreas F=C3=A4rber: > Am 23.04.2012 22:11, schrieb Stefan Weil: >> Am 13.04.2012 22:24, schrieb Stefan Weil: >>> This is a bitmap file (32x32x4) derived from the official QEMU=20 >>> mascot (which was designed by Beno=C3=AEt Canet). I stripped the text= =20 >>> from the SVG to get a nearly square image and converted the result=20 >>> to BMP without any manual optimization. The bitmap is currently used=20 >>> by QEMU's SDL interface and replaces the default X icon. v2: Add=20 >>> qemu-icon.bmp to Makefile. Signed-off-by: Stefan Weil=20 >>> --- Makefile | 1 + pc-bios/qemu-icon.bmp | Bin 0 ->=20 >>> 630 bytes 2 files changed, 1 insertions(+), 0 deletions(-) create=20 >>> mode 100644 pc-bios/qemu-icon.bmp=20 > It looks kind of ugly in GNOME3, where it is scaled up to some other=20 > resolution in the top bar. IIRC Windows 7 uses 64x64 max, Mac OS X=20 > 128x128 max, GNOME 48x48(?). When we add icons for Gtk+ and Cocoa we=20 > might also want to rename the file to indicate size and/or purpose=20 > (e.g., qemu-sdl-icon.bmp / qemu-32x32-icon.bmp). For Windows, wouldn't=20 > it be a better idea to use the multi-resolution .ico format through=20 > version.rc and to avoid the generic SDL icon being used? Don't see=20 > that being set up in this patch - #ifdef it out there? Andreas=20 Yes, there are other formats for the different hosts which look better and which are standard for the respective operating systems, but they also need special code and / or linker intructions. As far as I know, SDL supports only 32x32x4 bitmaps, so this icon is the best possible format which works on any host with SDL. I always wanted to have a QEMU specific icon for the QEMU executables (any host) and for the installer (w32/w64 only). That's why I wrote the SDL icon code and added this patch here. IMHO, improving the icon can be done when QEMU has an adequate GUI. Stefan