From: "Andreas Färber" <afaerber@suse.de>
To: Alexander Graf <agraf@suse.de>,
blauwirbel@gmail.com, malc <av1474@comtv.ru>
Cc: qemu-ppc@nongnu.org, qemu-devel Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 3/8] linux-user: Fix undefined HOST_LONG_SIZE on PPC hosts
Date: Tue, 01 May 2012 20:32:28 +0200 [thread overview]
Message-ID: <4FA02C3C.2080305@suse.de> (raw)
In-Reply-To: <1335862740-17408-4-git-send-email-agraf@suse.de>
Am 01.05.2012 10:58, schrieb Alexander Graf:
> On my PPC host, HOST_LONG_SIZE is not defined even after
> running configure. Use the normal C way of determining the
> long size instead.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
> thunk.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/thunk.h b/thunk.h
> index 5be8f91..87025c3 100644
> --- a/thunk.h
> +++ b/thunk.h
> @@ -113,7 +113,7 @@ static inline int thunk_type_size(const argtype *type_ptr, int is_host)
> defined(HOST_PARISC) || defined(HOST_SPARC64)
> return 4;
> #elif defined(HOST_PPC)
> - return HOST_LONG_SIZE;
> + return sizeof(void *);
malc has committed a different fix (TARGET_ABI_BITS / 8) - thanks for
fixing the build - but this PULL will now conflict.
Andreas
> #else
> return 2;
> #endif
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-05-01 18:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-01 8:58 [Qemu-devel] [PULL 0/8] ppc patch queue 2012-05-01 Alexander Graf
2012-05-01 8:58 ` [Qemu-devel] [PATCH 1/8] booke:Use MMU API for creating initial mapping for secondary cpus Alexander Graf
2012-05-01 8:58 ` [Qemu-devel] [PATCH 2/8] PPC: Fix up e500 cache size setting Alexander Graf
2012-05-01 8:58 ` [Qemu-devel] [PATCH 3/8] linux-user: Fix undefined HOST_LONG_SIZE on PPC hosts Alexander Graf
2012-05-01 18:32 ` Andreas Färber [this message]
2012-05-01 18:54 ` Alexander Graf
2012-05-01 19:11 ` Peter Maydell
2012-05-01 19:48 ` Alexander Graf
2012-05-01 8:58 ` [Qemu-devel] [PATCH 4/8] pseries: Implement automatic PAPR VIO address allocation Alexander Graf
2012-05-01 8:58 ` [Qemu-devel] [PATCH 5/8] pseries: Use the same interrupt swizzling for host bridges as p2p bridges Alexander Graf
2012-05-01 8:58 ` [Qemu-devel] [PATCH 6/8] pseries: Fix use of global CPU state Alexander Graf
2012-05-01 8:58 ` [Qemu-devel] [PATCH 7/8] ppce500_spin: Replace assert by hw_error (fixes compiler warning) Alexander Graf
2012-05-01 8:59 ` [Qemu-devel] [PATCH 8/8] target-ppc: Some support for dumping TLB_EMB TLBs Alexander Graf
-- strict thread matches above, loose matches on Subject: below --
2012-05-01 19:50 [Qemu-devel] [PULL 0/8] ppc patch queue 2012-05-01 Alexander Graf
2012-05-01 19:50 ` [Qemu-devel] [PATCH 3/8] linux-user: Fix undefined HOST_LONG_SIZE on PPC hosts Alexander Graf
2012-05-01 20:51 ` Stefan Weil
2012-05-01 21:02 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA02C3C.2080305@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=av1474@comtv.ru \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).