From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46383)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1SPIG8-0005A8-BZ
	for qemu-devel@nongnu.org; Tue, 01 May 2012 14:57:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1SPIG6-0007dr-J1
	for qemu-devel@nongnu.org; Tue, 01 May 2012 14:57:11 -0400
Received: from p15195424.pureserver.info ([82.165.34.74]:34324)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1SPIG6-0007dd-9i
	for qemu-devel@nongnu.org; Tue, 01 May 2012 14:57:10 -0400
Message-ID: <4FA03216.3010100@ilande.co.uk>
Date: Tue, 01 May 2012 19:57:26 +0100
From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
MIME-Version: 1.0
References: <4F9D797E.500@ilande.co.uk>
	<4F9D97F3.8080608@codemonkey.ws>	<4F9E5028.7010306@redhat.com>
	<4F9E82C7.10706@ilande.co.uk>	<4F9E9268.70408@redhat.com>	<CAFEAcA_sKtzmHpFcdhkANLCY0=FuW0Hbof0ifp3uHM66NkWoOQ@mail.gmail.com>	<4F9E9569.5000700@redhat.com>	<CAFEAcA_wFfsq=PwHAc_r-2bgdwUpSHaTOaL2VPVCJSs9x_JT6A@mail.gmail.com>	<4F9FD997.9000403@redhat.com>	<CAFEAcA9O8yYtJLS8coTruffwAfN4A96f6Y-Cdi6-Y7c1-G9aJA@mail.gmail.com>	<4F9FDA38.6030108@redhat.com>	<CAFEAcA9q4RSGAyY4T0dyCCxoJnP=RpcQ6JXNKC4ZgKm6jFCFFQ@mail.gmail.com>	<4F9FDB80.4020604@redhat.com>	<CAFEAcA9z833Ri62MadW0P8jbrVojXrurKmpcVS4S7Do7pDnttg@mail.gmail.com>	<4F9FDEBC.2030806@redhat.com>
	<4F9FEA24.3070603@codemonkey.ws>	<CAFEAcA-20nHPs_224sZVpnQrGmW_2tPhkTFLf_TAJhRpHL427A@mail.gmail.com>	<4F9FEDFE.3030403@codemonkey.ws>	<CAFEAcA8H7yNgnOyqmd2ZUL_QAJd6=V6-Vy13VSnaGXkqp7z1=Q@mail.gmail.com>	<4F9FFCA6.5070706@codemonkey.ws>
	<CAFEAcA_W5dTRiW9kZRHJzT6uVVUofFNCPAm3uPqCObqkois5uQ@mail.gmail.com>
In-Reply-To: <CAFEAcA_W5dTRiW9kZRHJzT6uVVUofFNCPAm3uPqCObqkois5uQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Memory API: handling unassigned physical memory
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Avi Kivity <avi@redhat.com>, Anthony Liguori <anthony@codemonkey.ws>, qemu-devel@nongnu.org

On 01/05/12 16:20, Peter Maydell wrote:

>> Correctness is more important to me than brevity.
>>
>> And really, we should focus on killing things like i8259_init().
>
> Functions like i8259_init() exist precisely because
> QOM/qdev don't provide brevity and people trying to
> use these devices do in fact value brevity. That's why
> I want the standard native "connect this thing to this
> other thing" function to be short and simple.

My understanding was that the *_init() functions were legacy and 
shouldn't be used any more - at least I've started removing them and 
replacing them with the slighty more long-winded QOM versions in my 
working tree.

Or should I just leave them as they are copy the bits I need to a 
separate initialisation function?


ATB,

Mark.