From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51841) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPJox-00010I-Ks for qemu-devel@nongnu.org; Tue, 01 May 2012 16:37:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SPJou-0004f8-OU for qemu-devel@nongnu.org; Tue, 01 May 2012 16:37:15 -0400 Received: from mail-we0-f173.google.com ([74.125.82.173]:58803) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPJou-0004eS-Fn for qemu-devel@nongnu.org; Tue, 01 May 2012 16:37:12 -0400 Received: by werp12 with SMTP id p12so3228465wer.4 for ; Tue, 01 May 2012 13:37:09 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4FA04974.30503@redhat.com> Date: Tue, 01 May 2012 22:37:08 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1335896294-9530-1-git-send-email-aliguori@us.ibm.com> <1335896294-9530-5-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1335896294-9530-5-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 04/14] qdev: don't allow globals to be set by bus name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Wanpeng Li , Peter Maydell , qemu-devel@nongnu.org, Andreas Faerber Il 01/05/2012 20:18, Anthony Liguori ha scritto: > This is technically a compatibility breaker. However: > > 1) libvirt does not rely on this (it always uses the driver name) > > 2) This behavior isn't actually documented anywhere (the docs just say driver). > > 3) I suspect there are less than three people on earth that even know this is > possible (minus the people reading this message). > > So I think we can safely break it :-) Does this work with compat properties set on a bus? Even if it does, perhaps it's better to avoid the cleverness and wait for my series that moves bus properties to the appropriate abstract superclass. Paolo