From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33676) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPK1S-00015X-Nv for qemu-devel@nongnu.org; Tue, 01 May 2012 16:50:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SPK1R-0001Ko-16 for qemu-devel@nongnu.org; Tue, 01 May 2012 16:50:10 -0400 Received: from e38.co.us.ibm.com ([32.97.110.159]:52377) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPK1Q-0001HR-Pn for qemu-devel@nongnu.org; Tue, 01 May 2012 16:50:08 -0400 Received: from /spool/local by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 1 May 2012 14:50:05 -0600 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id ADA813E40051 for ; Tue, 1 May 2012 14:49:35 -0600 (MDT) Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q41KmqYo117620 for ; Tue, 1 May 2012 14:49:07 -0600 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q41KnDO0028361 for ; Tue, 1 May 2012 14:49:13 -0600 Message-ID: <4FA04C23.4070403@us.ibm.com> Date: Tue, 01 May 2012 15:48:35 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1335896294-9530-1-git-send-email-aliguori@us.ibm.com> <1335896294-9530-4-git-send-email-aliguori@us.ibm.com> <4FA033EC.1050800@suse.de> <4FA0497D.3060103@us.ibm.com> <4FA04B0E.5040500@suse.de> In-Reply-To: <4FA04B0E.5040500@suse.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 03/14] qdev: add qdev_add_properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: Wanpeng Li , Peter Maydell , qemu-devel@nongnu.org, Paolo Bonzini On 05/01/2012 03:43 PM, Andreas Färber wrote: > Am 01.05.2012 22:37, schrieb Anthony Liguori: >> On 05/01/2012 02:05 PM, Andreas Färber wrote: >>> Am 01.05.2012 20:18, schrieb Anthony Liguori: >>>> This allows a base class to easily add properties. >>>> >>>> Signed-off-by: Anthony Liguori >>> >>> Implementation looks okay but /me not so happy with it: This conflicts >>> with the move of the qdev static property infrastructure from >>> DeviceState to Object. >>> >>> Consider rebasing this onto part of Paolo's series and call it >>> object_add_properties? >> >> Eh? There's nothing object_ about these properties and there's no way >> I'm willing to put legacy properties in object... >> >> So I'm not quite sure what you're suggesting. > > You just suggested to Peter using qdev_add_properties() in new QOM ARM > classes of his. > > I'd rather not propagate using qdev_* functions in new QOM code because > either it remains forever or renaming becomes another touch-all series. > > In Paolo's series the Property* concept is moved from qdev to QOM; thus > if it's in Object we usually use an object_ prefix. > Not too long ago you were willing to merge the large part of Paolo's > series which included this code movement, so if you don't want that > after all you should communicate that openly as a reply there. :) Legacy properties != static properties. qdev_add_properties adds both legacy and static properties. I'm happy to put static properties into object but not legacy properties. So qdev_add_properties is going to stick around even after Paolo's changes. Base classes are free to call object_property_add_static directly and avoid qdev_add_properties entirely but we need the later for backwards compat. Regards, Anthony Liguori > > Andreas >