From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57917)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SPKuv-0000fC-OL
	for qemu-devel@nongnu.org; Tue, 01 May 2012 17:47:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SPKut-00066D-Sz
	for qemu-devel@nongnu.org; Tue, 01 May 2012 17:47:29 -0400
Received: from mail-wg0-f53.google.com ([74.125.82.53]:58078)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SPKut-00065n-KS
	for qemu-devel@nongnu.org; Tue, 01 May 2012 17:47:27 -0400
Received: by wgbfm10 with SMTP id fm10so1955533wgb.10
	for <qemu-devel@nongnu.org>; Tue, 01 May 2012 14:47:25 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4FA059EA.1060900@redhat.com>
Date: Tue, 01 May 2012 23:47:22 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1335896294-9530-1-git-send-email-aliguori@us.ibm.com>
	<1335896294-9530-5-git-send-email-aliguori@us.ibm.com>
	<4FA04974.30503@redhat.com> <4FA04B92.3080200@us.ibm.com>
In-Reply-To: <4FA04B92.3080200@us.ibm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 04/14] qdev: don't allow globals to be set
	by bus name
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Wanpeng Li <liwp@linux.vnet.ibm.com>, Andreas Faerber <afaerber@suse.de>, qemu-devel@nongnu.org

Il 01/05/2012 22:46, Anthony Liguori ha scritto:
>>>
>>>
>>> So I think we can safely break it :-)
>>
>> Does this work with compat properties set on a bus?
> 
> No :-(
> 
> This is pretty easy to fix though.  The attached should do the trick,
> I'll update and send out.
> 
>   Even if it does,
>> perhaps it's better to avoid the cleverness and wait for my series that
>> moves bus properties to the appropriate abstract superclass.
> 
> This series does that FWIW (patch 6/14).

Yeah, it should---modulo bisectability of course.

It's a fairly different approach WRT my series (using
qdev_add_properties instead of klass->props).  In theory I like it, but
I fail to see right now whether it breaks "-device foo,?" somehow.  I
think it does:

$ qemu-system-x86_64 -device rtl8139,?
rtl8139.mac=macaddr
rtl8139.vlan=vlan
rtl8139.netdev=netdev
rtl8139.bootindex=int32
rtl8139.addr=pci-devfn                   <<< here start bus props
rtl8139.romfile=string
rtl8139.rombar=uint32
rtl8139.multifunction=on/off
rtl8139.command_serr_enable=on/off

I think it's too late for this series to go into 1.1.

Paolo