From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55464) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPLVE-0002ba-Uz for qemu-devel@nongnu.org; Tue, 01 May 2012 18:25:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SPLVD-0003oV-96 for qemu-devel@nongnu.org; Tue, 01 May 2012 18:25:00 -0400 Received: from e33.co.us.ibm.com ([32.97.110.151]:37125) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPLVD-0003o4-31 for qemu-devel@nongnu.org; Tue, 01 May 2012 18:24:59 -0400 Received: from /spool/local by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 1 May 2012 16:24:54 -0600 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 707F0C9005C for ; Tue, 1 May 2012 18:24:33 -0400 (EDT) Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q41MOZkV125016 for ; Tue, 1 May 2012 18:24:35 -0400 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q41MPBLt000899 for ; Tue, 1 May 2012 16:25:11 -0600 Message-ID: <4FA062A1.2030208@us.ibm.com> Date: Tue, 01 May 2012 17:24:33 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1335896294-9530-1-git-send-email-aliguori@us.ibm.com> <1335896294-9530-12-git-send-email-aliguori@us.ibm.com> <4FA03AE0.6010102@suse.de> In-Reply-To: <4FA03AE0.6010102@suse.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 11/14] qbus: move get_fw_dev_path to DeviceClass List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: Wanpeng Li , Peter Maydell , qemu-devel@nongnu.org, Paolo Bonzini On 05/01/2012 02:34 PM, Andreas Färber wrote: > Am 01.05.2012 20:18, schrieb Anthony Liguori: >> It should have never been a bus method. >> >> Signed-off-by: Anthony Liguori >> --- > [...] >> diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c >> index 4a468f8..5044018 100644 >> --- a/hw/ide/qdev.c >> +++ b/hw/ide/qdev.c >> @@ -25,22 +25,13 @@ >> >> /* --------------------------------- */ >> >> -static char *idebus_get_fw_dev_path(DeviceState *dev); >> - >> #define TYPE_IDE_BUS "IDE" >> - >> -static void ide_bus_class_init(ObjectClass *klass, void *data) >> -{ >> - BusClass *k = BUS_CLASS(klass); >> - >> - k->get_fw_dev_path = idebus_get_fw_dev_path; >> -} >> +#define IDE_BUS(obj) OBJECT_CHECK(IDEBus, (obj), TYPE_IDE_BUS) > > Move macro to preceding patch? > > Otherwise looks good. Do you mean an independent patch? Regards, Anthony Liguori > > /-F >