From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41403)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1SPTgT-0007TK-73
	for qemu-devel@nongnu.org; Wed, 02 May 2012 03:09:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1SPTgM-0002yT-U3
	for qemu-devel@nongnu.org; Wed, 02 May 2012 03:09:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38607)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1SPTgM-0002vQ-MM
	for qemu-devel@nongnu.org; Wed, 02 May 2012 03:09:02 -0400
Message-ID: <4FA0DD87.6080302@redhat.com>
Date: Wed, 02 May 2012 09:08:55 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1335559216-13849-1-git-send-email-lcapitulino@redhat.com>
	<1335559216-13849-3-git-send-email-lcapitulino@redhat.com>
In-Reply-To: <1335559216-13849-3-git-send-email-lcapitulino@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/3] runstate: introduce suspended state
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com

> diff --git a/input.c b/input.c
> index 6b5c2c3..47e6900 100644
> --- a/input.c
> +++ b/input.c
> @@ -130,7 +130,7 @@ void qemu_remove_led_event_handler(QEMUPutLEDEntry *entry)
>  
>  void kbd_put_keycode(int keycode)
>  {
> -    if (!runstate_is_running()) {
> +    if (!runstate_is_running() && !runstate_check(RUN_STATE_SUSPENDED)) {
>          return;
>      }
>      if (qemu_put_kbd_event) {

IIRC there is a simliar check for the mouse ...

Does it make sense to add a runstate_is_running_or_suspended() function?

Overall the series looks good to me.

cheers,
  Gerd