From: Kevin Wolf <kwolf@redhat.com>
To: "Andreas Färber" <andreas.faerber@web.de>
Cc: blauwirbel@gmail.com, Ben Leslie <benno@benno.id.au>,
qemu-devel@nongnu.org,
Pavel Borzenkov <pavel.borzenkov@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] raw-posix: Do not use CONFIG_COCOA macro
Date: Wed, 02 May 2012 10:02:51 +0200 [thread overview]
Message-ID: <4FA0EA2B.2070805@redhat.com> (raw)
In-Reply-To: <1335824128-16819-2-git-send-email-andreas.faerber@web.de>
Am 01.05.2012 00:15, schrieb Andreas Färber:
> From: Pavel Borzenkov <pavel.borzenkov@gmail.com>
>
> Use __APPLE__ and __MACH__ macros instead of CONFIG_COCOA to detect Mac
> OS X host. The patch is based on Ben Leslie's patch:
> http://patchwork.ozlabs.org/patch/97859/
>
> Signed-off-by: Ben Leslie <benno@benno.id.au>
> Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
> Signed-off-by: Andreas Färber <andreas.faerber@web.de>
> ---
> block/raw-posix.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/block/raw-posix.c b/block/raw-posix.c
> index 2d1bc13..03fcfcc 100644
> --- a/block/raw-posix.c
> +++ b/block/raw-posix.c
> @@ -29,7 +29,7 @@
> #include "module.h"
> #include "block/raw-posix-aio.h"
>
> -#ifdef CONFIG_COCOA
> +#if defined(__APPLE__) && (__MACH__)
Is there a 'defined' missing?
Kevin
next prev parent reply other threads:[~2012-05-02 8:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1335824128-16819-1-git-send-email-andreas.faerber@web.de>
2012-05-01 11:45 ` [Qemu-devel] [PULL] Cocoa patch queue 2012-05-01 Blue Swirl
[not found] ` <1335824128-16819-2-git-send-email-andreas.faerber@web.de>
2012-05-02 8:02 ` Kevin Wolf [this message]
2012-05-02 9:39 ` [Qemu-devel] [PATCH 1/3] raw-posix: Do not use CONFIG_COCOA macro Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA0EA2B.2070805@redhat.com \
--to=kwolf@redhat.com \
--cc=andreas.faerber@web.de \
--cc=benno@benno.id.au \
--cc=blauwirbel@gmail.com \
--cc=pavel.borzenkov@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).