From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39777) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPUWq-0001ZE-7O for qemu-devel@nongnu.org; Wed, 02 May 2012 04:03:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SPUWi-0007Ui-Pb for qemu-devel@nongnu.org; Wed, 02 May 2012 04:03:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19135) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPUWi-0007U7-Go for qemu-devel@nongnu.org; Wed, 02 May 2012 04:03:08 -0400 Message-ID: <4FA0EA2B.2070805@redhat.com> Date: Wed, 02 May 2012 10:02:51 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1335824128-16819-1-git-send-email-andreas.faerber@web.de> <1335824128-16819-2-git-send-email-andreas.faerber@web.de> In-Reply-To: <1335824128-16819-2-git-send-email-andreas.faerber@web.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/3] raw-posix: Do not use CONFIG_COCOA macro List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: blauwirbel@gmail.com, Ben Leslie , qemu-devel@nongnu.org, Pavel Borzenkov Am 01.05.2012 00:15, schrieb Andreas F=C3=A4rber: > From: Pavel Borzenkov >=20 > Use __APPLE__ and __MACH__ macros instead of CONFIG_COCOA to detect Mac > OS X host. The patch is based on Ben Leslie's patch: > http://patchwork.ozlabs.org/patch/97859/ >=20 > Signed-off-by: Ben Leslie > Signed-off-by: Pavel Borzenkov > Signed-off-by: Andreas F=C3=A4rber > --- > block/raw-posix.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/block/raw-posix.c b/block/raw-posix.c > index 2d1bc13..03fcfcc 100644 > --- a/block/raw-posix.c > +++ b/block/raw-posix.c > @@ -29,7 +29,7 @@ > #include "module.h" > #include "block/raw-posix-aio.h" > =20 > -#ifdef CONFIG_COCOA > +#if defined(__APPLE__) && (__MACH__) Is there a 'defined' missing? Kevin