From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPVBl-0008LU-1j for qemu-devel@nongnu.org; Wed, 02 May 2012 04:45:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SPUzL-00026J-Dm for qemu-devel@nongnu.org; Wed, 02 May 2012 04:34:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56777) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPUzL-000263-4K for qemu-devel@nongnu.org; Wed, 02 May 2012 04:32:43 -0400 Message-ID: <4FA0F121.5030903@redhat.com> Date: Wed, 02 May 2012 10:32:33 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20120328053356.34135.42669.stgit@amd-6168-8-1.englab.nay.redhat.com> <20120328054012.34135.77090.stgit@amd-6168-8-1.englab.nay.redhat.com> <4FA0E6F7.1070605@redhat.com> <4FA0E976.9050808@redhat.com> In-Reply-To: <4FA0E976.9050808@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [V6 PATCH 1/4] net: announce self after vm start List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang Cc: aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, mst@redhat.com, rusty@rustcorp.com.au, qemu-devel@nongnu.org, Orit Wasserman , quintela@redhat.com Il 02/05/2012 09:59, Jason Wang ha scritto: > I don't like this external flag. As this is only related to migration > I think we can add a new state RUN_STATE_MIG_PRELAUNCH. In vm_start > call qemu_announce_self only if the state was > RUN_STATE_MIG_PRELAUNCH. This will we useful if we will need to do > something else when resuming a migrated guest. I don't think this global is replacing a runstate. It is simply saying that some work has been delayed to the next time the CPU runs. Perhaps we can instead use a runstate-change notifier and keep the global hidden to vl.c. Paolo