From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47459)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SPVFk-0001Vr-1d
	for qemu-devel@nongnu.org; Wed, 02 May 2012 04:49:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SPVFi-0008Ea-Ca
	for qemu-devel@nongnu.org; Wed, 02 May 2012 04:49:39 -0400
Received: from mx1.redhat.com ([209.132.183.28]:2282)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SPV0n-0002dA-6P
	for qemu-devel@nongnu.org; Wed, 02 May 2012 04:34:13 -0400
Message-ID: <4FA0F17D.7030906@redhat.com>
Date: Wed, 02 May 2012 10:34:05 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1335896294-9530-1-git-send-email-aliguori@us.ibm.com>
	<1335896294-9530-15-git-send-email-aliguori@us.ibm.com>
In-Reply-To: <1335896294-9530-15-git-send-email-aliguori@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 14/14] qbus: initialize in standard way
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Wanpeng Li <liwp@linux.vnet.ibm.com>, Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Andreas Faerber <afaerber@suse.de>

Il 01/05/2012 20:18, Anthony Liguori ha scritto:
>      if (bus->qdev_allocated) {
> -        g_free(bus);
> +        object_delete(OBJECT(bus));
> +    } else {
> +        object_finalize(OBJECT(bus));
>      }

Time is ripe to add a more versatile freeing mechanism along the lines
you've set in the past (either a callback or a notifier that object_new
would set to a g_free wrapper).  Anthony, are you going to do this?

Paolo