From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38889)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1SPXSS-0007M2-4i
	for qemu-devel@nongnu.org; Wed, 02 May 2012 07:11:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1SPXSN-0001Vi-Gn
	for qemu-devel@nongnu.org; Wed, 02 May 2012 07:10:55 -0400
Received: from cantor2.suse.de ([195.135.220.15]:41719 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1SPXSN-0001VB-Ah
	for qemu-devel@nongnu.org; Wed, 02 May 2012 07:10:51 -0400
Message-ID: <4FA1163A.4090603@suse.de>
Date: Wed, 02 May 2012 13:10:50 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1335448165-26174-1-git-send-email-borntraeger@de.ibm.com>
	<1335448165-26174-2-git-send-email-borntraeger@de.ibm.com>
	<4F9AC55F.5000101@redhat.com> <4FA109F6.3090107@de.ibm.com>
	<4FA10B9F.9040909@redhat.com> <4FA1117F.3070908@de.ibm.com>
	<4FA1155A.6080400@suse.de> <4FA115CE.5010008@redhat.com>
In-Reply-To: <4FA115CE.5010008@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/3] Fix geometry sector calculation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Heinz Graalfs <graalfs@linux.vnet.ibm.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Christian Borntraeger <borntraeger@de.ibm.com>, Jens Freimann <jfrei@linux.vnet.ibm.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, wein@linux.vnet.ibm.com, Christoph Hellwig <hch@lst.de>

On 05/02/2012 01:09 PM, Paolo Bonzini wrote:
> Il 02/05/2012 13:07, Alexander Graf ha scritto:
>> Both can be accessed using virtio-blk-s390. The former have the same
>> semantics on geometry as what we're used to. They use normal MBRs and
>> essentially the geometry doesn't mean too much these days anymore ;).
>> However, if possible, I would like to diverge these as little as
>> possible from x86 virtio disks.
> If anything, the geometry should be guessed like we do on x86.
>
>> For DASD disks, the geometry is important, as its disk label is usually
>> not MBR, but something s390 specific.
> Can we use this to guess the geometry like we do on x86?

Yes, but what do you do with a blank disk? :)


Alex