From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56636) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPXqQ-0008Ki-Cr for qemu-devel@nongnu.org; Wed, 02 May 2012 07:35:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SPXqK-0001uk-95 for qemu-devel@nongnu.org; Wed, 02 May 2012 07:35:41 -0400 Received: from cantor2.suse.de ([195.135.220.15]:43455 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPXqK-0001ug-2d for qemu-devel@nongnu.org; Wed, 02 May 2012 07:35:36 -0400 Message-ID: <4FA11C06.10400@suse.de> Date: Wed, 02 May 2012 13:35:34 +0200 From: Alexander Graf MIME-Version: 1.0 References: <6715e896-3fdb-4223-a33b-cecbbf6785ac@zmail13.collab.prod.int.phx2.redhat.com> In-Reply-To: <6715e896-3fdb-4223-a33b-cecbbf6785ac@zmail13.collab.prod.int.phx2.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] geometry detection: use HDIO_GETGEO List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Heinz Graalfs , qemu-devel , Christian Borntraeger , Jens Freimann , Cornelia Huck , Einar Lueck On 05/02/2012 01:26 PM, Paolo Bonzini wrote: >> and everyone should be happy :). I would really like to have as >> little #ifdef TARGET_S390 code in QEMU. And #ifdef __s390__ is even worse, >> as it means we won't be able to execise that code path on other >> architectures. > True, but how do you exercise that code path with DASD geometry > on !__s390__? If we make things a flag for the guessing code, it should work just as well with image files, right? Alex