From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53175) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPXwD-0002Lb-MY for qemu-devel@nongnu.org; Wed, 02 May 2012 07:41:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SPXw9-0003qM-01 for qemu-devel@nongnu.org; Wed, 02 May 2012 07:41:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18806) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPXw8-0003qD-P3 for qemu-devel@nongnu.org; Wed, 02 May 2012 07:41:36 -0400 Message-ID: <4FA11D6A.7020407@redhat.com> Date: Wed, 02 May 2012 13:41:30 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1335958273-769-1-git-send-email-pbonzini@redhat.com> <1335958273-769-13-git-send-email-pbonzini@redhat.com> <20120502113856.GA32746@redhat.com> In-Reply-To: <20120502113856.GA32746@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 12/21] pc: add back PCI.rombar compat property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, qemu-devel@nongnu.org, afaerber@suse.de, liwp@linux.vnet.ibm.com Il 02/05/2012 13:38, Michael S. Tsirkin ha scritto: > On Wed, May 02, 2012 at 01:31:04PM +0200, Paolo Bonzini wrote: >> This was erroneously dropped in d6c730086cbf24382eb8cff25551798769edfd84. >> >> Cc: Michael S. Tsirkin >> Signed-off-by: Paolo Bonzini > > Yes I think it's a mistake, however we had: > - },{ > - .driver = "PCI", > - .property = "rombar", > - .value = stringify(0), > - },{ > > and not TYPE_PCI_DEVICE. PCI->TYPE_PCI_DEVICE is required by earlier patches in the series. Paolo