From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35861) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPYm7-0005D2-CD for qemu-devel@nongnu.org; Wed, 02 May 2012 08:35:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SPYlx-0002vn-Cs for qemu-devel@nongnu.org; Wed, 02 May 2012 08:35:18 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47982 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPYlx-0002vZ-6Y for qemu-devel@nongnu.org; Wed, 02 May 2012 08:35:09 -0400 Message-ID: <4FA129FB.6070001@suse.de> Date: Wed, 02 May 2012 14:35:07 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1335958273-769-1-git-send-email-pbonzini@redhat.com> <1335958273-769-6-git-send-email-pbonzini@redhat.com> In-Reply-To: <1335958273-769-6-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 05/21] qom: assert that public types have a non-NULL parent field List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, qemu-devel@nongnu.org, liwp@linux.vnet.ibm.com Am 02.05.2012 13:30, schrieb Paolo Bonzini: > This protects against unwanted effects of changing TYPE_OBJECT from > NULL to a string. Suggested by Andreas Faerber. >=20 > Signed-off-by: Paolo Bonzini > --- > include/qemu/object.h | 1 - > qom/object.c | 14 ++++++++++---- > 2 files changed, 10 insertions(+), 5 deletions(-) >=20 > diff --git a/include/qemu/object.h b/include/qemu/object.h > index 9c49d99..ec2b382 100644 > --- a/include/qemu/object.h > +++ b/include/qemu/object.h > @@ -527,7 +527,6 @@ const char *object_get_typename(Object *obj); > */ > Type type_register_static(const TypeInfo *info); > =20 > -#define type_register_static_alias(info, name) do { } while (0) Unrelated removal of unused code? Other than that Reviewed-by: Andreas F=E4rber Thanks, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg