From: "Andreas Färber" <andreas.faerber@web.de>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Blue Swirl <blauwirbel@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Lee Essen <lee.essen@nowonline.co.uk>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] slirp: Untangle TCPOLEN_* from TCPOPT_*
Date: Wed, 02 May 2012 15:40:53 +0200 [thread overview]
Message-ID: <4FA13965.4070906@web.de> (raw)
In-Reply-To: <b12081a9-c239-4534-8fc0-832a20fabfbc@zmail13.collab.prod.int.phx2.redhat.com>
Am 02.05.2012 15:24, schrieb Paolo Bonzini:
>> But that would leave Illumos broken.
For the record, reverting would leave whatever Paolo was fixing broken
but would restore Illumos.
> I'd rather apply this one.
>
> Please do. The right solution for 1.2 is to understand the places in which
> slirp cannot use netinet/tcp.h constants (the MSS for example), and
> otherwise use that header.
Jan, should I prepare a mechanical prefix addition as suggested by Blue?
Should we apply this ugly-but-least-intrusive build fix? Or do you have
any other preference or idea?
Andreas
next prev parent reply other threads:[~2012-05-02 13:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAAu8pHty6LknkHcQseB29X4qQxguezAShsC5aGzMYHO1WRpJwg@mail.gmail.com>
2012-05-02 13:24 ` [Qemu-devel] [PATCH] slirp: Untangle TCPOLEN_* from TCPOPT_* Paolo Bonzini
2012-05-02 13:40 ` Andreas Färber [this message]
2012-05-02 13:48 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA13965.4070906@web.de \
--to=andreas.faerber@web.de \
--cc=blauwirbel@gmail.com \
--cc=jan.kiszka@web.de \
--cc=lee.essen@nowonline.co.uk \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).