From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36022)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1SPZpi-0008Qu-Ti
	for qemu-devel@nongnu.org; Wed, 02 May 2012 09:43:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1SPZpg-0003cj-RZ
	for qemu-devel@nongnu.org; Wed, 02 May 2012 09:43:06 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58994)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1SPZpg-0003cV-Jf
	for qemu-devel@nongnu.org; Wed, 02 May 2012 09:43:04 -0400
Message-ID: <4FA139DB.1080407@redhat.com>
Date: Wed, 02 May 2012 15:42:51 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1335247809.13579.1.camel@nzhmlwks0057.ad.endace.com>
	<1335248739.13579.17.camel@nzhmlwks0057.ad.endace.com>
	<20120425014802.GA14063@morn.localdomain>
	<4F9798C3.3090405@endace.com>
	<20120425125145.GB13225@morn.localdomain>
	<4F981840.2000902@redhat.com>
	<20120426124548.GA17409@morn.localdomain>
In-Reply-To: <20120426124548.GA17409@morn.localdomain>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH 11/12] Migrate 64bit entries to
	64bit pci regions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: Alexey Korolev <alexey.korolev@endace.com>, sfd@endace.com, seabios@seabios.org, qemu-devel@nongnu.org

  Hi,

> Is this just a matter of removing the "if (pci_bdf_to_bus(pci->bdf) !=
> 0) break" from pci_bios_init_devices()?

Seems to do the trick, at least the disks connected appear in the boot
menu now and the seabios log file looks sane.

The guest kernel has no virtio-scsi drivers though, need to update it
for more testing.

> The code should probably handle the irq swizzling that pci bridges do
> though.

i.e. add bridge handling to pci_slot_get_irq() ?

cheers,
  Gerd