From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53584) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPbqm-0003Os-9R for qemu-devel@nongnu.org; Wed, 02 May 2012 11:52:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SPbqk-0002IL-A5 for qemu-devel@nongnu.org; Wed, 02 May 2012 11:52:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10819) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPbqk-0002I5-1M for qemu-devel@nongnu.org; Wed, 02 May 2012 11:52:18 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q42FqGN1006081 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 2 May 2012 11:52:16 -0400 Message-ID: <4FA1582E.10503@redhat.com> Date: Wed, 02 May 2012 18:52:14 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1335967335-30197-1-git-send-email-kraxel@redhat.com> <1335967335-30197-2-git-send-email-kraxel@redhat.com> <4FA15361.7060905@redhat.com> <4FA156E8.2040200@redhat.com> In-Reply-To: <4FA156E8.2040200@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] pc: add pci64 memory hole List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On 05/02/2012 06:46 PM, Gerd Hoffmann wrote: > On 05/02/12 17:31, Avi Kivity wrote: > > On 05/02/2012 05:02 PM, Gerd Hoffmann wrote: > >> This patch adds a address space hole for 64bit PCI ressources. > >> It starts at 0x8000000000 (512 GB) and ends at 0x10000000000 (1 TB), > >> thus has 512 GB in size. This matches what the seabios is doing > >> (latest master branch). > > > > We should communicate this to seabios via fwcfg > > A dsdt entry is needed for the pci64 window (see > http://code.coreboot.org/p/seabios/source/commit/482a020ec25f4cec655ddcb16b67c6f38b0844c0/), > which makes it non-trivial to turn this into a runtime option ... It's a function, isn't it? So all you need is a ASL driver for fwcfg and an If(). > > It should also only apply to -M old. > > Is this the only reason you want this be runtime-switchable? No. The BIOS and qemu shouldn't be making too many assumptions. Certainly for Q35 we'd have the bios program qemu for the 64 bit hole. -- error compiling committee.c: too many arguments to function