From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59819) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPcdN-0003vW-GT for qemu-devel@nongnu.org; Wed, 02 May 2012 12:42:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SPcdK-00067V-UB for qemu-devel@nongnu.org; Wed, 02 May 2012 12:42:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5420) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPcdK-000679-LB for qemu-devel@nongnu.org; Wed, 02 May 2012 12:42:30 -0400 Message-ID: <4FA163F0.6090307@redhat.com> Date: Wed, 02 May 2012 18:42:24 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1335853005-8711-1-git-send-email-josh.durgin@dreamhost.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] rbd: add discard support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Josh Durgin , qemu-devel@nongnu.org Am 01.05.2012 10:39, schrieb Stefan Hajnoczi: > On Tue, May 1, 2012 at 7:16 AM, Josh Durgin wrote: >> Change the write flag to an operation type in RBDAIOCB, and make the >> buffer optional since discard doesn't use it. >> >> Discard is first included in librbd 0.1.2 (which is in Ceph 0.46). >> If librbd is too old, leave out qemu_rbd_aio_discard entirely, >> so the old behavior is preserved. >> >> Signed-off-by: Josh Durgin >> --- >> block/rbd.c | 89 ++++++++++++++++++++++++++++++++++++++++++++++++---------- >> 1 files changed, 73 insertions(+), 16 deletions(-) > > Reviewed-by: Stefan Hajnoczi Thanks, applied to the block branch. Kevin