From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33933) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQ2Ey-0001b6-Ak for qemu-devel@nongnu.org; Thu, 03 May 2012 16:03:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SQ2Ew-0005gS-Gq for qemu-devel@nongnu.org; Thu, 03 May 2012 16:03:03 -0400 Received: from david.siemens.de ([192.35.17.14]:20474) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQ2Ew-0005fW-7F for qemu-devel@nongnu.org; Thu, 03 May 2012 16:03:02 -0400 Message-ID: <4FA2E46B.4070609@siemens.com> Date: Thu, 03 May 2012 17:02:51 -0300 From: Jan Kiszka MIME-Version: 1.0 References: <4FA2D4C8.7010007@siemens.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1.1] audio: Always call fini on exit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: qemu-devel On 2012-05-03 16:32, malc wrote: > On Thu, 3 May 2012, Jan Kiszka wrote: > >> Not only clean up enabled voices but any registered one. Backends like >> pulsaudio rely on unconditional fini handler invocations. >> >> This fixes "Memory pool destroyed but not all memory blocks freed!" >> warnings on VM shutdowns when pa is used. > > Perhaps it's better to actually handle VOICE_DISABLE in pa's ctl_[in|out]? This might be some additional issue (that pa is not supporting enable/disable). In any case, it is unrelated to this one: fini corresponds to init. And as we initialized the voice, we also have to finalize it on shutdown. That's what this patch is fixing. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux