From: Anthony Liguori <anthony@codemonkey.ws>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] unreviewed commits (was: Re: Restore consistent formatting)
Date: Thu, 03 May 2012 19:41:33 -0500 [thread overview]
Message-ID: <4FA325BD.40201@codemonkey.ws> (raw)
In-Reply-To: <CAFEAcA_a2Cr5nrC3DtSc+X7gXYtMw1TTG+Qm_g4Tk409zLQCVA@mail.gmail.com>
On 05/03/2012 02:58 PM, Peter Maydell wrote:
> On 9 February 2012 13:46, Anthony Liguori<anthony@codemonkey.ws> wrote:
>> On 02/09/2012 03:48 AM, Markus Armbruster wrote:
>>> You buried the one truly important sentence, let me dig it out for you:
>>>
>>> *** Patches should always go to the mailing list ***
>>>
>>> Exceptions need justification. Responsible handling embargoed security
>>> issues may qualify. Style fixes certainly not.
>>
>> 100% agreed.
>
> I don't see anything in the mailing list archives corresponding
> to commits f05ae537, f6af014e.
>
> No unreviewed patches should go double when we're in hardfreeze!
These patches are admittedly trivial but it is important to stress the point
that all patches need to go on the mailing list before being committed.
It's an important part of keeping the development process inclusive. I don't
think it's reasonable to ask for an Acked-by on something as simple as
indentation changes but at the same time, there's no reason not to just post
patches.
Regards,
Anthony Liguori
>
> -- PMM
>
next prev parent reply other threads:[~2012-05-04 0:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 19:58 [Qemu-devel] unreviewed commits (was: Re: Restore consistent formatting) Peter Maydell
2012-05-04 0:41 ` Anthony Liguori [this message]
2012-05-04 1:07 ` Andreas Färber
2012-05-04 2:37 ` malc
2012-05-04 10:09 ` Alexander Graf
2012-05-06 8:57 ` Blue Swirl
2012-05-06 9:03 ` malc
2012-05-06 9:39 ` Blue Swirl
2012-05-06 9:46 ` malc
2012-05-06 10:01 ` Blue Swirl
2012-05-06 10:17 ` malc
2012-05-06 10:49 ` Blue Swirl
2012-05-06 11:02 ` malc
2012-05-06 11:24 ` Blue Swirl
2012-05-06 14:41 ` [Qemu-devel] unreviewed commits Andreas Färber
2012-05-06 16:22 ` Alexander Graf
2012-05-06 21:31 ` Richard Henderson
2012-05-06 19:58 ` Blue Swirl
2012-05-04 10:04 ` [Qemu-devel] unreviewed commits (was: Re: Restore consistent formatting) Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA325BD.40201@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).